Re: [RFC PATCH 1/1] Input: add new keycodes useful in mobile devices

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jani Nikula <ext-jani.1.nikula@nokia.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] Input: add new keycodes useful in mobile devices
Date: Fri, 23 Oct 2009 00:13:15 -0700	[thread overview]
Message-ID: <20091023071315.GA3986@core.coreip.homeip.net> (raw)
In-Reply-To: <72a6deb76f693b5e50dbfe150154e7a4724d0568.1256200562.git.ext-jani.1.nikula@nokia.com>

Hi Jani,

On Thu, Oct 22, 2009 at 12:32:20PM +0300, Jani Nikula wrote:
> From: Jani Nikula <ext-jani.1.nikula@nokia.com>
> 
> Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
> ---
>  include/linux/input.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/input.h b/include/linux/input.h
> index 0ccfc30..3c246b1 100644
> --- a/include/linux/input.h
> +++ b/include/linux/input.h
> @@ -595,6 +595,8 @@ struct input_absinfo {
>  #define KEY_NUMERIC_STAR	0x20a
>  #define KEY_NUMERIC_POUND	0x20b
>  
> +#define KEY_CAMERA_FOCUS	0x210

I believe that this has already been discussed and I am OK with adding
such keycode, as long and there are in-kernel users.

> +
>  /* We avoid low common keys in module aliases so they don't get huge. */
>  #define KEY_MIN_INTERESTING	KEY_MUTE
>  #define KEY_MAX			0x2ff
> @@ -677,6 +679,9 @@ struct input_absinfo {
>  #define SW_LINEOUT_INSERT	0x06  /* set = inserted */
>  #define SW_JACK_PHYSICAL_INSERT 0x07  /* set = mechanical switch set */
>  #define SW_VIDEOOUT_INSERT	0x08  /* set = inserted */
> +#define SW_CAMERA_LENSE_COVER	0x09  /* set = lense covered */
> +#define SW_KEYPAD_SLIDE		0x0a  /* set = keypad slide out */
> +#define SW_PROXIMITY		0x0b  /* set = proximity sensor covered */

Don't quite like the name for this one, any alternatives?

>  #define SW_MAX			0x0f
>  #define SW_CNT			(SW_MAX+1)
>  

Thanks.

-- 
Dmitry