Re: [PATCH 10/10] thinkpad-acpi: sync input device EV_SW state directly

From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Henrique de Moraes Holschuh
	<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
Cc: linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Alan Jenkins
	<alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>,
	Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 10/10] thinkpad-acpi: sync input device EV_SW state directly
Date: Tue, 8 Dec 2009 17:45:14 -0800	[thread overview]
Message-ID: <200912081745.14725.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <1260322590-5571-11-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>

On Tuesday 08 December 2009 05:36:30 pm Henrique de Moraes Holschuh wrote:
> Before we register the input device, sync the input layer EV_SW state
> directly by setting the bitmaps, to avoid issuing a gratuitous event
> for the initial state of these switches.
> 
> I will propose a clean input layer API for this and change the driver
> to use it later, but I'd rather get the driver fix in mainline ASAP.
> 

Just do input_report_switch() before registering the device, it will do
the right thing.

Input core guarantees (and will continue doing so) that it is safe to
pass events to the device as soon as it was allocated with
input_allocate_device().

-- 
Dmitry

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev