From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
Mika Westerberg <mika.westerberg@iki.fi>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
linux-pm@lists.linux-foundation.org,
Ferenc Wagner <wferi@niif.hu>
Subject: Re: [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags
Date: Wed, 9 Dec 2009 13:48:42 -0800 [thread overview]
Message-ID: <20091209214841.GE10138__22428.7749654197$1260395588$gmane$org@core.coreip.homeip.net> (raw)
In-Reply-To: <20091209210816.GD3480@elf.ucw.cz>
On Wed, Dec 09, 2009 at 10:08:16PM +0100, Pavel Machek wrote:
> > > > I refuse it because it will be supported by exactly 1 driver in the
> > > > kernel - gpio-keys. It is the only driver that allows shut half of the
> > > > "device" (because in reality it is a group of disjoint devices). It is
> > > > the only case when "muting" a button means that IRQ is shut off abnd
> > > > thus CPU can continue to sleep if that button is pressed. For all other
> > > > devices that have 1 inettrupt per device, you still have to wake up,
> > > > because you don't know whether the button that generated event is
> > > > "important" or not.
> > >
> > > Fair enough.
> > >
> > > > Now, there is a issue of waking up userspace task, additional scheduling
> > > > and keeping CPU running longer than necessary for "uninteresting" keys.
> > > > This can be solved by implementing a subscription model which allows
> > > > filtering uninteresing events on a per-client basis at evdev level.
> > >
> > > Right. And for gpio_keys, this would be dine on the driver level.
> >
> > But the semantics are different - if done on driver level you'd be
> > affecting _all_ consumers of the device; what I want to be done only
> > affects owner of the file descriptor.
>
> Well, if _all_ consumers decide to ignore some key, we should be able
> to ignore it at driver level.
The intesection of drivers allowing shut off individual buttons with
all consumers agreeing on not using a key would be pretty miniscule.
>
> And actually it may make some sense -- I do not think disabling irq
> during runtime is worth the effort, but disabling wakeup source and
> getting rid of unneccessary wakeup when system is suspended is
> probably worth it.
>
I don't believe Mika's patches touched wakeup in any way. So it has
been strictly about wakig up processor to service that interrupt so far.
--
Dmitry
next prev parent reply other threads:[~2009-12-09 21:48 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 12:15 [RFC PATCH 0/1] Enabling/disabling separate gpio-keys buttons Mika Westerberg
2009-10-23 12:15 ` [RFC PATCH 1/1] Input: gpio-keys: export gpio key information through sysfs Mika Westerberg
2009-10-28 5:43 ` Dmitry Torokhov
2009-10-28 10:50 ` Mika Westerberg
2009-11-04 9:06 ` Mika Westerberg
2009-11-04 9:25 ` Artem Bityutskiy
2009-11-06 7:52 ` Dmitry Torokhov
2009-11-09 15:09 ` Artem Bityutskiy
2009-11-09 17:18 ` Dmitry Torokhov
2009-11-10 11:04 ` Artem Bityutskiy
2009-11-10 17:19 ` Dmitry Torokhov
2009-11-11 6:50 ` Artem Bityutskiy
2009-11-11 8:19 ` Dmitry Torokhov
2009-11-11 8:52 ` Artem Bityutskiy
2009-11-11 9:59 ` Dmitry Torokhov
2009-11-11 10:26 ` Artem Bityutskiy
2009-11-11 10:30 ` Artem Bityutskiy
2009-11-11 17:40 ` Dmitry Torokhov
2009-11-12 5:31 ` Artem Bityutskiy
2009-11-19 7:23 ` [PATCH 0/2] Input: gpio-keys: support for disabling GPIOs Mika Westerberg
2009-11-19 7:23 ` [PATCH 1/2] Input: gpio-keys: allow drivers to specify whether IRQ can be shared Mika Westerberg
2009-11-19 7:23 ` [PATCH 2/2] Input: gpio-keys: added support for disabling gpios through sysfs Mika Westerberg
2009-11-20 8:40 ` Dmitry Torokhov
2009-11-20 12:17 ` Mika Westerberg
2009-11-23 12:39 ` [PATCH v2 0/2] Input: gpio-keys: support for disabling GPIOs Mika Westerberg
2009-11-23 12:39 ` [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags Mika Westerberg
2009-11-23 12:39 ` [PATCH v2 2/2] Input: gpio-keys - added support for disabling gpios through sysfs Mika Westerberg
2009-11-23 16:42 ` [PATCH v2 1/2] Input: gpio-keys - allow platform to specify exact irq flags Ferenc Wagner
2009-11-23 17:24 ` Dmitry Torokhov
2009-11-23 18:50 ` Ferenc Wagner
2009-11-24 6:37 ` Mika Westerberg
2009-11-24 11:05 ` Ferenc Wagner
2009-11-24 17:02 ` Mika Westerberg
2009-11-24 18:39 ` Ferenc Wagner
2009-11-26 6:35 ` Dmitry Torokhov
2009-11-27 10:54 ` Mika Westerberg
2009-11-28 12:16 ` Ferenc Wagner
2009-11-28 13:27 ` Mika Westerberg
2009-11-29 12:26 ` Ferenc Wagner
2009-11-29 12:26 ` Ferenc Wagner
2009-11-29 16:04 ` Alan Stern
2009-11-29 16:04 ` [linux-pm] " Alan Stern
2009-11-29 22:58 ` Ferenc Wagner
2009-11-30 8:27 ` Mika Westerberg
2009-11-30 8:27 ` [linux-pm] " Mika Westerberg
2009-11-30 9:14 ` Dmitry Torokhov
2009-11-30 9:14 ` [linux-pm] " Dmitry Torokhov
2009-11-30 9:37 ` Mika Westerberg
2009-11-30 9:37 ` [linux-pm] " Mika Westerberg
2009-12-01 0:07 ` Ferenc Wagner
2009-11-30 20:59 ` Ferenc Wagner
2009-12-01 0:37 ` Dmitry Torokhov
2009-12-01 1:05 ` Ferenc Wagner
2009-11-29 22:58 ` Ferenc Wagner
2009-11-30 9:16 ` [linux-pm] " Dmitry Torokhov
2009-11-30 15:00 ` Alan Stern
2009-11-30 19:05 ` Ferenc Wagner
2009-11-30 19:05 ` [linux-pm] " Ferenc Wagner
2009-11-30 19:30 ` Alan Stern
2009-11-30 20:51 ` Ferenc Wagner
2009-11-30 21:59 ` Alan Stern
2009-11-30 21:59 ` [linux-pm] " Alan Stern
2009-12-01 10:08 ` Ferenc Wagner
2009-12-01 10:08 ` [linux-pm] " Ferenc Wagner
2009-12-01 15:11 ` Alan Stern
2009-12-01 15:11 ` Alan Stern
2009-11-30 20:51 ` Ferenc Wagner
2009-11-30 19:30 ` Alan Stern
2009-12-06 8:47 ` Pavel Machek
2009-12-06 8:47 ` [linux-pm] " Pavel Machek
2009-12-08 4:22 ` Dmitry Torokhov
2009-12-08 13:03 ` Artem Bityutskiy
2009-12-08 13:03 ` [linux-pm] " Artem Bityutskiy
2009-12-08 17:42 ` Dmitry Torokhov
2009-12-08 17:42 ` [linux-pm] " Dmitry Torokhov
2009-12-09 7:31 ` Artem Bityutskiy
2009-12-09 7:31 ` [linux-pm] " Artem Bityutskiy
2009-12-09 18:03 ` Dmitry Torokhov
2009-12-09 21:08 ` Pavel Machek
2009-12-09 21:48 ` Dmitry Torokhov [this message]
2009-12-09 21:48 ` Dmitry Torokhov
2009-12-10 10:13 ` Pavel Machek
2009-12-10 10:13 ` Pavel Machek
2009-12-09 21:08 ` Pavel Machek
2009-12-10 9:19 ` [linux-pm] " Artem Bityutskiy
2009-12-10 9:19 ` Artem Bityutskiy
2009-12-09 18:03 ` Dmitry Torokhov
2009-12-08 4:22 ` Dmitry Torokhov
2009-11-30 15:00 ` Alan Stern
2009-11-30 9:16 ` Dmitry Torokhov
2009-12-06 8:46 ` [linux-pm] " Pavel Machek
2009-12-06 8:46 ` Pavel Machek
2009-11-20 8:38 ` [PATCH 1/2] Input: gpio-keys: allow drivers to specify whether IRQ can be shared Dmitry Torokhov
2009-11-20 10:08 ` Ferenc Wagner
2009-11-11 10:36 ` [RFC PATCH 0/2] Input: adding new ioctl()s for enabling/disabling events Mika Westerberg
2009-11-11 10:36 ` [RFC PATCH 1/2] Input: added 2 new ioctl()s for setting/getting event state Mika Westerberg
2009-11-11 10:36 ` [RFC PATCH 2/2] Input: gpio-keys: implemented support for enabling/disabling gpios Mika Westerberg
2009-11-11 14:37 ` Ferenc Wagner
2009-11-11 14:52 ` Mika Westerberg
2009-11-11 17:08 ` Dmitry Torokhov
2009-11-12 6:23 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20091209214841.GE10138__22428.7749654197$1260395588$gmane$org@core.coreip.homeip.net' \
--to=dmitry.torokhov@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mika.westerberg@iki.fi \
--cc=pavel@ucw.cz \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.