From: Al Viro <viro@ZenIV.linux.org.uk>
To: liu weni <qingshenlwy@gmail.com>
Cc: chris.mason@oracle.com, joel.becker@oracle.com, cjb@laptop.org,
jmorris@namei.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, onlyflyer@gmail.com,
strongzgy@gmail.com
Subject: Re: [PATCHv2 02/12]posix_acl: Add the check items
Date: Tue, 22 Dec 2009 14:48:51 +0000 [thread overview]
Message-ID: <20091222144851.GS18217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <b3657a100912220631n4d69ea66x23c1296e1abc468a@mail.gmail.com>
On Tue, Dec 22, 2009 at 10:31:38PM +0800, liu weni wrote:
> Hi All:
>
> I'm sorry for my stupid. I am crazy for fixing this bug.
> And make so much mistake.
Welcome to the club. It's OK, _everyone_ around here had done that.
Many times.
> Maybe I need cool down and think more.
Always a good advice, but in this case it's a bit more specific - if you
see that you are modifying behaviour for some arguments, figure out what
would lead to such arguments and see if that behaviour is intentional ;-)
And if after that you are still not sure whether it's a bug or not, ask the
people involved what the hell had they intended to happen in such-and-such
case (often enough that'll bring variants of "nice catch" - bugs *do* happen).
prev parent reply other threads:[~2009-12-22 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 11:52 [PATCHv2 02/12]posix_acl: Add the check items Liuwenyi
2009-12-21 11:52 ` Liuwenyi
2009-12-22 12:08 ` Al Viro
2009-12-22 14:31 ` liu weni
2009-12-22 14:31 ` liu weni
2009-12-22 14:48 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222144851.GS18217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chris.mason@oracle.com \
--cc=cjb@laptop.org \
--cc=jmorris@namei.org \
--cc=joel.becker@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=onlyflyer@gmail.com \
--cc=qingshenlwy@gmail.com \
--cc=strongzgy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.