All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Yinghai Lu <yinghai@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-arch@vger.kernel.org, torvalds@linux-foundation.org,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 1/2] resource: align functions now return start of resource
Date: Sun, 3 Jan 2010 17:30:52 +0100	[thread overview]
Message-ID: <20100103163052.GA5282@comet.dominikbrodowski.net> (raw)
In-Reply-To: <86802c441001011412u1543c1afk6337cd6d3ea0f257@mail.gmail.com>

Hey,

On Fri, Jan 01, 2010 at 02:12:09PM -0800, Yinghai Lu wrote:
> > -                       res->start = start;
> > -               }
> > -       }
> > +       if ((res->flags & IORESOURCE_IO) && (start & 0x300))
> > +               start = (start + 0x3ff) & ~0x3ff;
> > +
> > +       return start
> 
> missed ; here?

Indeed -- thanks for the hint.

Best,
	Dominik

  reply	other threads:[~2010-01-03 16:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-20  9:50 [PATCH] resources: fix call to alignf() in allocate_resource() Dominik Brodowski
2009-12-20 18:33 ` Linus Torvalds
2009-12-20 22:12   ` Bjorn Helgaas
2009-12-21  8:40   ` Dominik Brodowski
2009-12-21 16:03     ` Linus Torvalds
2010-01-01 16:38       ` [RFC] improve alignf() calling convention " Dominik Brodowski
2010-01-01 16:40         ` [PATCH 1/2] resource: align functions now return start of resource Dominik Brodowski
2010-01-01 16:40           ` Dominik Brodowski
2010-01-01 22:12           ` Yinghai Lu
2010-01-01 22:12             ` Yinghai Lu
2010-01-03 16:30             ` Dominik Brodowski [this message]
2010-01-15 18:23           ` Jesse Barnes
2010-01-15 18:23             ` Jesse Barnes
2010-01-15 18:23             ` Jesse Barnes
2010-01-01 16:40         ` [PATCH 2/2] resource: mark struct resource as const Dominik Brodowski
2010-01-01 16:40           ` Dominik Brodowski
2010-01-14  7:28       ` why can not receive kernel mail anymore? goldenwang1979

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100103163052.GA5282@comet.dominikbrodowski.net \
    --to=linux@dominikbrodowski.net \
    --cc=bjorn.helgaas@hp.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.