Re: [PATCH] backlight, classmate-laptop: fix missing registration failure handling

From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Daniel Oliveira Nascimento <don@syst.com.br>,
	Richard Purdie <rpurdie@linux.intel.com>,
	linux-kernel@vger.kernel.org, mjg@redhat.com
Subject: Re: [PATCH] backlight, classmate-laptop: fix missing registration failure handling
Date: Fri, 26 Feb 2010 13:20:03 -0300	[thread overview]
Message-ID: <20100226162002.GE23453@holoscopio.com> (raw)
In-Reply-To: <20100226125939.7cda6d46@neptune.home>

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

Mathew,

Please apply the following patch.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

On Fri, Feb 26, 2010 at 12:59:39PM +0100, Bruno Prémont wrote:
> Check newly registered backlight_device for error and properly
> return error to parent.
> Mark struct backlight_ops as const.
> 
> Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
> ---
>  drivers/platform/x86/classmate-laptop.c |    2 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index bfae789..66f6aad 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -452,7 +452,7 @@ static int cmpc_bl_update_status(struct backlight_device *bd)
>  		return -1;
>  }
>  
> -static struct backlight_ops cmpc_bl_ops = {
> +static const struct backlight_ops cmpc_bl_ops = {
>  	.get_brightness = cmpc_bl_get_brightness,
>  	.update_status = cmpc_bl_update_status
>  };
> @@ -463,6 +463,8 @@ static int cmpc_bl_add(struct acpi_device *acpi)
>  
>  	bd = backlight_device_register("cmpc_bl", &acpi->dev,
>  				       acpi->handle, &cmpc_bl_ops);
> +	if (IS_ERR(bd))
> +		return PTR_ERR(bd);
>  	bd->props.max_brightness = 7;
>  	dev_set_drvdata(&acpi->dev, bd);
>  	return 0;
> -- 
> 1.6.4.4
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]