From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, linux-input@vger.kernel.org
Subject: Re: [Uclinux-dist-devel] [PATCH v2] input/misc: PCF8574 I2C keypad input device driver
Date: Tue, 9 Mar 2010 14:30:39 -0800 [thread overview]
Message-ID: <20100309223038.GB29517@core.coreip.homeip.net> (raw)
In-Reply-To: <8bd0f97a1003091327y5f5596eelb60b3c52694517b1@mail.gmail.com>
On Tue, Mar 09, 2010 at 04:27:48PM -0500, Mike Frysinger wrote:
> On Tue, Mar 9, 2010 at 16:21, Dmitry Torokhov wrote:
> > On Tue, Mar 09, 2010 at 04:01:53PM -0500, Mike Frysinger wrote:
> >> From: Bryan Wu <cooloney@kernel.org>
> >>
> >> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >> ---
> >> v2
> >> - process all feedback from Dmitry except for threaded irqs; that'll have to be done later
> >
> > Could I ask why? As it stands the remove() is racy WRT to a work
> > running. But if you simply add cancel_work_sync() you'll risk leaving
> > unbalanced enable_irq()/disable_irq().
>
> ive never worked with threaded irq handlers before. i'll have to read
> about them before i can do the work. i'm not suggesting you take the
> driver now as is ... having it on a list in case someone else wants a
> mostly-ok driver.
It is very simple, take a look at drivers/input/touchscreen/mcs5000_ts.c
Just make sure you request threaded irq with IRQF_ONESHOT.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-09 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 15:01 [PATCH] input/misc: PCF8574 I2C keypad input device driver Mike Frysinger
2010-03-09 18:09 ` Dmitry Torokhov
2010-03-09 21:01 ` [PATCH v2] " Mike Frysinger
2010-03-09 21:21 ` Dmitry Torokhov
2010-03-09 21:27 ` [Uclinux-dist-devel] " Mike Frysinger
2010-03-09 22:30 ` Dmitry Torokhov [this message]
2010-03-10 4:36 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309223038.GB29517@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.