From: Daniel Vetter <daniel@ffwll.ch>
To: Jerome Glisse <glisse@freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.sourceforge.net
Subject: Re: [PATCH 00/14] cleanup radeon_asic.h
Date: Thu, 11 Mar 2010 17:10:17 +0100 [thread overview]
Message-ID: <20100311161016.GC3446@viiv.ffwll.ch> (raw)
In-Reply-To: <20100311154601.GA3033@barney.localdomain>
On Thu, Mar 11, 2010 at 04:46:01PM +0100, Jerome Glisse wrote:
> On Thu, Mar 11, 2010 at 02:06:02PM +0100, Daniel Vetter wrote:
> > Hi all,
> >
> > This patch pile moves the "static struct radeon_asic <asic>" definitions
> > form radeon_asic.h into the asic-specific files, where I think they belong.
> > This way radeon_asic.h becomes a real header file that can be #included.
> > And indeed, with all the copy&pasting of function declarations, one has
> > gotten out of sync.
> >
> > The next step would be to collect asic specific declarations in
> > radeon_asic.h - atm they are somewhat scattered. But this can easily be
> > done on the go and has way too much potential for conflicts with other
> > patches. So I didn't do this.
> >
> > Tested on my rv570.
> >
> > Comments higly welcome.
> >
> > Yours, Daniel
>
> It all looks good from a quick read through of the patches. For
> gathering asic function prototype i kind of started adding them
> to radeon.h at the bottom (there is already a bunch of them). Thus
> i think radeon_asic.h can be kill and extern declaration directly
> put into radeon_asic.c
Yes, I've noticed that radeon.h has started to accumulate some
declarations (because radeon_asic.h could not be included, I think).
IMHO radeon.h is already growing out of bounds, so my plan was to move
these declarations to radeon_asic.h. Most of the functions are only used
by the asic specific support code (eg. r600 the blit stuff) so would only
pollute the general namespace in radeon.h
Does that sound reasonable?
btw, radeon_asic.c doesn't exist here in my tree.
> Cheers,
> Jerome
Cheers, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
next prev parent reply other threads:[~2010-03-11 16:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 13:06 [PATCH 00/14] cleanup radeon_asic.h Daniel Vetter
2010-03-11 13:06 ` [PATCH 01/14] drm/radoen: move r100 asic struct to r100.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 02/14] drm/radoen: move r200 asic struct to r200.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 03/14] drm/radeon: move r300 asic structs to r300.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 04/14] drm/radeon: move r420 asic struct to r420.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 05/14] drm/radoen: move rs400 asic struct to rs400.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 06/14] drm/radoen: move rs600 asic struct to rs600.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 07/14] drm/radoen: move rs690 asic struct to rs690.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 08/14] drm/radoen: move rv515 asic struct to rv515.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 09/14] drm/radoen: move r520 asic struct to r520.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 10/14] drm/radoen: move r600 asic struct to r600.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 11/14] drm/radoen: move rv770 asic struct to rv770.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 12/14] drm/radoen: move evergreen asic struct to evergreen.c Daniel Vetter
2010-03-11 13:06 ` [PATCH 13/14] drm/radoen: unconfuse return value of radeon_asic->clear_surface_reg Daniel Vetter
2010-03-11 13:06 ` [PATCH 14/14] drm/radeon: include radeon_asic.h in <asic>.c Daniel Vetter
2010-03-11 15:46 ` [PATCH 00/14] cleanup radeon_asic.h Jerome Glisse
2010-03-11 16:10 ` Daniel Vetter [this message]
2010-03-11 15:54 ` Alex Deucher
2010-03-11 16:05 ` Daniel Vetter
2010-03-11 16:24 ` Rafał Miłecki
2010-03-11 16:34 ` Jerome Glisse
2010-03-11 16:38 ` Alex Deucher
2010-03-11 16:40 ` Daniel Vetter
2010-03-11 20:52 ` Dave Airlie
2010-03-11 21:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311161016.GC3446@viiv.ffwll.ch \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.sourceforge.net \
--cc=glisse@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.