From: Kenneth Graunke <kenneth@whitecape.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: add power monitoring support
Date: Fri, 21 May 2010 23:55:43 -0700 [thread overview]
Message-ID: <201005212355.43400.kenneth@whitecape.org> (raw)
In-Reply-To: <20100520142811.314a5e80@virtuousgeek.org>
Jesse,
This patch seems to have a lot of magical numbers in it. In particular,
v_table and cparams both seem rather cryptic. Would it be possible to add a
few comments saying what these numbers mean or where they came from?
Thanks,
--Kenneth
prev parent reply other threads:[~2010-05-22 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 21:27 [PATCH 1/2] IPS driver: add GPU busy and turbo checking Jesse Barnes
2010-05-20 21:28 ` [PATCH 2/2] drm/i915: add power monitoring support Jesse Barnes
2010-05-22 6:55 ` Kenneth Graunke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005212355.43400.kenneth@whitecape.org \
--to=kenneth@whitecape.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.