From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: use wake_up instead of drm wrapper.
Date: Fri, 28 May 2010 09:05:01 -0700 [thread overview]
Message-ID: <20100528090501.129c791c@virtuousgeek.org> (raw)
In-Reply-To: <AANLkTilnk3PdUewQ_TqWONbCoaiOW3-5eCggA0IYCbHL@mail.gmail.com>
On Fri, 28 May 2010 19:55:24 +1000
Dave Airlie <airlied@gmail.com> wrote:
> On Fri, May 28, 2010 at 7:12 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Fri, May 28, 2010 at 01:02:08PM +1000, Dave Airlie wrote:
> >> This fixes a regression in the copy fb code we use to get seamless
> >> startup on Fedora/RHEL, without this fix, we block forever in the wait
> >> when starting X.
> >
> > I've just checked latest -linus and found in include/drm/drm_os_linux.h:
> >
> > #define DRM_WAKEUP( queue ) wake_up( queue )
> >
> > It's been like that since I've originally wrote the uninterruptible sleep
> > stuff for the intel overlay code (I've checked way back then to make sure
> > it doesn't hang). Care to explain how this fixes a regression?
> >
>
> doh, you fixed that in the patch, and for some reason we don't have
> that in our Fedora or RHEL backports wierd.
>
> Ignore this.
>
> I don't remember much discussion on changing drm_os_linux, but it
> should have been fine.
We should still kill the drm_os_linux bits where possible...
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-05-28 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 3:02 [PATCH] drm/i915: use wake_up instead of drm wrapper Dave Airlie
2010-05-28 9:12 ` Daniel Vetter
2010-05-28 9:55 ` Dave Airlie
2010-05-28 16:05 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528090501.129c791c@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.