Re: [ANNOUNCE] xf86-video-intel 2.11.901

From: "Marc Deop i Argemí" <damnshock@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [ANNOUNCE] xf86-video-intel 2.11.901
Date: Wed, 16 Jun 2010 18:12:38 +0200	[thread overview]
Message-ID: <201006161812.39012.damnshock@gmail.com> (raw)
In-Reply-To: <89k304$iplh2g@orsmga001.jf.intel.com>

On Wednesday June 16 2010 15:57:41 Chris Wilson wrote:
> One more step. Test that commit and tell git bisect (good|bad) and it will
> print a slightly more verbose statement of which commit is triggering the
> freeze.

Sometimes I amaze myself :S It clearly says *after* this.

I'll do that tonight

However, I have to comment that the system has been stable with the 2.12RC for 
two hours after applying this patch from my distribution (Archlinux):

diff -up xf86-video-intel-2.11.0/src/drmmode_display.c.no-flip xf86-video-
intel-2.11.0/src/drmmode_display.c

--- xf86-video-intel-2.11.0/src/drmmode_display.c.no-flip	2010-05-03 
15:30:19.000000000 -0400
+++ xf86-video-intel-2.11.0/src/drmmode_display.c	2010-05-03 
15:30:59.000000000 -0400
@@ -1504,10 +1504,15 @@ Bool drmmode_pre_init(ScrnInfoPtr scrn, 
 	gp.value = &has_flipping;
 	(void)drmCommandWriteRead(intel->drmSubFD, DRM_I915_GETPARAM, &gp,
 				  sizeof(gp));
+
+        xf86DrvMsg(scrn->scrnIndex, X_INFO,
+                   "Pageflipping %s in kernel, %s disabled in X\n",
+                   has_flipping ? "enabled" : "disabled",
+                   has_flipping ? "but" : "and");
 	if (has_flipping) {
 		xf86DrvMsg(scrn->scrnIndex, X_INFO,
-			   "Kernel page flipping support detected, enabling\n");
-		intel->use_pageflipping = TRUE;
+			   "Don't panic: https://bugzilla.redhat.com/588421\n");
+		intel->use_pageflipping = FALSE;
 		drmmode->flip_count = 0;
 		drmmode->event_context.version = DRM_EVENT_CONTEXT_VERSION;
 		drmmode->event_context.vblank_handler = drmmode_vblank_handler;
diff -up xf86-video-intel-2.11.0/src/i830_dri.c.no-flip xf86-video-
intel-2.11.0/src/i830_dri.c
--- xf86-video-intel-2.11.0/src/i830_dri.c.no-flip	2010-03-29 
14:23:02.000000000 -0400
+++ xf86-video-intel-2.11.0/src/i830_dri.c	2010-05-03 15:30:19.000000000 
-0400
@@ -1013,7 +1013,7 @@ Bool I830DRI2ScreenInit(ScreenPtr screen
 
 	info.CopyRegion = I830DRI2CopyRegion;
 #if DRI2INFOREC_VERSION >= 4
-	if (intel->use_pageflipping) {
+	if (intel->use_pageflipping || 1) {
 	    info.version = 4;
 	    info.ScheduleSwap = I830DRI2ScheduleSwap;
 	    info.GetMSC = I830DRI2GetMSC;
-- 
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
