Re: [PATCH 1/2] Input: ads7846 - allow specifying irq trigger type in platform data

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Anatolij Gustschin <agust@denx.de>
Cc: linux-input@vger.kernel.org, Detlev Zundel <dzu@denx.de>
Subject: Re: [PATCH 1/2] Input: ads7846 - allow specifying irq trigger type in platform data
Date: Mon, 28 Jun 2010 01:32:08 -0700	[thread overview]
Message-ID: <20100628083208.GD25287@core.coreip.homeip.net> (raw)
In-Reply-To: <20100625113534.77524c85@wker>

On Fri, Jun 25, 2010 at 11:35:34AM +0200, Anatolij Gustschin wrote:
> On Mon, 31 May 2010 21:28:20 +0200
> Anatolij Gustschin <agust@denx.de> wrote:
> 
> > Hi Dmitry,
> > 
> > On Fri, 30 Apr 2010 14:23:00 +0200
> > Anatolij Gustschin <agust@denx.de> wrote:
> > 
> > > On some platforms, for example with GPIO interrupts
> > > on mpc5121, it is not possible to configure falling edge
> > > interrupts.
> > > 
> > > Specifying irq trigger type in platform data structure
> > > allows using ads7846 driver on such platforms.
> > > 
> > > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > > ---
> > >  drivers/input/touchscreen/ads7846.c |    5 ++++-
> > >  include/linux/spi/ads7846.h         |    1 +
> > >  2 files changed, 5 insertions(+), 1 deletions(-)
> > 
> > Any comments on these patches?
> 
> Ping? The patches still apply on top of the input.git/next branch.
> 

I applied the first one (however changed irq_trigger to be unsigned
long) however I'd like better changelog for 7845 changes.

Thanks.

-- 
Dmitry