From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: linux-input@vger.kernel.org
Subject: Re: question on releasing keys
Date: Thu, 1 Jul 2010 09:11:01 -0700 [thread overview]
Message-ID: <20100701161101.GC4152@core.coreip.homeip.net> (raw)
In-Reply-To: <201005061533.49845.oneukum@suse.de>
On Thu, May 06, 2010 at 03:33:49PM +0200, Oliver Neukum wrote:
> Am Mittwoch, 28. April 2010 18:42:24 schrieb Dmitry Torokhov:
> > Hi Oliver,
> >
> > On Wednesday 28 April 2010 01:53:52 am Oliver Neukum wrote:
> > > Hi,
> > >
> > > I am seeing a generic problem with buttons on devices released during S3.
> > > The input layer then assumes that the button is still pressed. It would be
> > > best for drivers to either verify that a button is still held or
> > > alternatively, to release all buttons upon resumption. Is there a generic
> > > way to do that?
> > >
> >
> > I think input core should force release of all keys when device is
> > being suspended, I guess we need to change input.c::input_dev_reset().
>
> Something like this?
>
> Regards
> Oliver
>
> From 96c19e9e0c6164655600e764a9b5c3a6f132723d Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@neukum.org>
> Date: Thu, 6 May 2010 15:30:28 +0200
> Subject: [PATCH] input: release pressed keys during resume()
>
> As the kernel has no way to know whether a key was released
> while the system was asleep, keys need to be reported released
> as the system is resumed, lest autorepeat set in.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
Applied, thanks Oliver.
--
Dmitry
prev parent reply other threads:[~2010-07-01 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 8:53 question on releasing keys Oliver Neukum
2010-04-28 16:42 ` Dmitry Torokhov
2010-05-06 13:33 ` Oliver Neukum
2010-07-01 16:11 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701161101.GC4152@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.