From: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: be sure panel is powered up in eDP configs
Date: Thu, 22 Jul 2010 13:19:50 -0700 [thread overview]
Message-ID: <20100722131950.7c470161@virtuousgeek.org> (raw)
In-Reply-To: <20100714154056.208b30c9@virtuousgeek.org>
On Wed, 14 Jul 2010 15:40:56 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=28739. We need to
> enable power to the panel with the AUX VDD bit in order to properly
> detect the eDP attached panel, and we also need to turn the panel on in
> case it was off when we started (as happens at resume time).
>
> But this patch raises a couple of questions:
> 1) why does the first panel on sequence time out?
> 2) why do I need to unlock the panel protected regs?
>
> Keith, I think this is your code, any ideas?
Just posted a more minimal fix and separated out the register patch.
Apparently we just need to unlock the panel regs around the actual
power on sequence. Talking with the hw guys about this now as there
may be a better workaround to the broken panel sequencing logic.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-07-22 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 22:40 [PATCH] drm/i915: be sure panel is powered up in eDP configs Jesse Barnes
2010-07-15 0:27 ` Keith Packard
2010-07-15 1:13 ` Zhenyu Wang
2010-07-15 21:42 ` ILK/SNB mode setting sequence Jesse Barnes
2010-07-22 3:09 ` [PATCH] drm/i915: be sure panel is powered up in eDP configs Sergio Monteiro Basto
2010-07-22 20:19 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722131950.7c470161@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.