From: Matt Fleming <matt@console-pimps.org>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: Kyungmin Park <kmpark@infradead.org>,
linux-mmc@vger.kernel.org,
Anton Vorontsov <cbouatmailru@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [patch 1/1]sdhci: sdhc spec 3.0 add some modification
Date: Tue, 10 Aug 2010 17:32:44 +0100 [thread overview]
Message-ID: <20100810163244.GA12837@console-pimps.org> (raw)
In-Reply-To: <AANLkTinqToYc6bizV7AcKuk-4XiNA08qhqfCPN1WLo8S@mail.gmail.com>
On Mon, Aug 09, 2010 at 08:33:16PM +0800, zhangfei gao wrote:
>
> Thanks for your careful review, in our platform, we use max/min for
> the max_div, so miss this modification :(
> Update the patch, help review again.
What do you mean? Where does max/min come from? It would definitely
be best if everybody uses the same code to calculate max_div. Have
you tested the max_div changes? Are you now using this patch on
your platform or are you still maintaining a patch to do it a
different way?
If you've got a separate patch and it does this things better
than the way we currently do them, get it upstream! :-)
next prev parent reply other threads:[~2010-08-10 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 6:08 [patch 1/1]sdhci: sdhc spec 3.0 add some modification zhangfei gao
2010-08-05 6:33 ` Kyungmin Park
2010-08-05 7:09 ` zhangfei gao
2010-08-09 10:10 ` Matt Fleming
2010-08-09 12:33 ` zhangfei gao
2010-08-10 16:32 ` Matt Fleming [this message]
2010-08-11 7:44 ` zhangfei gao
2010-08-12 6:46 ` zhangfei gao
2010-08-13 16:25 ` Michał Mirosław
2010-08-16 3:09 ` zhangfei gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810163244.GA12837@console-pimps.org \
--to=matt@console-pimps.org \
--cc=ben-linux@fluff.org \
--cc=cbouatmailru@gmail.com \
--cc=kmpark@infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.