From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/11] drm/i915: Avoid using msleep under kdb and wait_for()
Date: Wed, 11 Aug 2010 08:20:22 -0700 [thread overview]
Message-ID: <20100811082022.2662fbd5@virtuousgeek.org> (raw)
In-Reply-To: <1281519096-5152-2-git-send-email-chris@chris-wilson.co.uk>
On Wed, 11 Aug 2010 10:31:26 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> wait_for() uses msleep() to yield the cpu whilst spinning waiting for a
> register to change. kdb asserts that mode changes are atomic and so
> prohibits msleep. The alternative would be to use mdelay or to simply
> probe the register more often instead of busy waiting.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_drv.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index e6351e6..d93b7f0 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -41,7 +41,7 @@
> ret__ = -ETIMEDOUT; \
> break; \
> } \
> - if (W) msleep(W); \
> + if (W && !in_dbg_master()) msleep(W); \
> } \
> ret__; \
> })
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-08-11 15:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 9:31 Remaining set of small patches for -rc1 Chris Wilson
2010-08-11 9:31 ` [PATCH 01/11] drm/i915: Avoid using msleep under kdb and wait_for() Chris Wilson
2010-08-11 15:20 ` Jesse Barnes [this message]
2010-08-11 9:31 ` [PATCH 02/11] drm/i915: Include a generation number in the device info Chris Wilson
2010-08-11 15:22 ` Jesse Barnes
2010-08-11 9:31 ` [PATCH 03/11] drm/i915: Fix offset page-flips on i965+ Chris Wilson
2010-08-11 9:31 ` [PATCH 04/11] drm/i915: Clear scanline waits after disabling the pipe Chris Wilson
2010-08-11 15:23 ` Jesse Barnes
2010-08-11 16:12 ` Chris Wilson
2010-08-11 9:31 ` [PATCH 05/11] drm/i915: Sanity check user framebuffer parameters on creation Chris Wilson
2010-08-11 9:31 ` [PATCH 06/11] drm/i915: Re-use set_base_atomic to share setting of the display registers Chris Wilson
2010-08-11 15:25 ` Jesse Barnes
2010-08-11 9:31 ` [PATCH 07/11] drm/i915/sdvo: Propagate error from switching control buses Chris Wilson
2010-08-11 9:31 ` [PATCH 08/11] drm/i915: Add RING_WAIT reset to hangcheck Chris Wilson
2010-08-22 6:19 ` Eric Anholt
2010-08-22 8:50 ` [PATCH] drm/i915: Add ringbuffer wait " Chris Wilson
2010-08-11 9:31 ` [PATCH 09/11] drm/i915/crt: Flush register prior to waiting for vblank Chris Wilson
2010-08-11 9:31 ` [PATCH 10/11] drm/i915/dp: Boost timeout for enabling transcoder to 100ms Chris Wilson
2010-08-11 9:31 ` [PATCH 11/11] drm/i915: Perform initial configuration asynchronously Chris Wilson
2010-08-11 9:46 ` Remaining set of small patches for -rc1 shadi
2010-08-11 15:21 ` Alan W. Irwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100811082022.2662fbd5@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.