From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: "Xiang, Haihao" <haihao.xiang@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in struct intel_ring_buffer
Date: Thu, 16 Sep 2010 13:37:49 +0800 [thread overview]
Message-ID: <20100916053749.GP9765@zhen-devel.sh.intel.com> (raw)
In-Reply-To: <1284613829.24494.24.camel@xhh-ctg32>
[-- Attachment #1.1: Type: text/plain, Size: 583 bytes --]
On 2010.09.16 13:10:29 +0800, Xiang, Haihao wrote:
> > Or can't that be done in init function by using advance_ring?
> advance_ring uses ring->tail to set TAIL register, i965_reset() also
> invokes ring->init() to re-init ring buffer, how to guarantee ring->tail
> is 0? BTW advance_ring can be implemented as set_tail(dev, ring->tail).
>
oh, that's bad, not only just for render ring, but ring tail should
always be inited correctly, not just in static variable..
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2010-09-16 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 2:43 [Inter-gfx][PATCH][v3 1/4] drm/i915: fix HAS_BSD with a device info flag Xiang, Haihao
2010-09-16 2:43 ` [Inter-gfx][PATCH][v3 2/4] drm/i915: do not export the instances of struct intel_ring_buffer Xiang, Haihao
2010-09-16 2:43 ` [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in " Xiang, Haihao
2010-09-16 4:21 ` Zhenyu Wang
2010-09-16 5:10 ` Xiang, Haihao
2010-09-16 5:37 ` Zhenyu Wang [this message]
2010-09-16 6:03 ` Xiang, Haihao
2010-09-16 2:43 ` [Inter-gfx][PATCH][v3 4/4] drm/i915: add a new ring buffer on Sandybridge Xiang, Haihao
2010-09-19 13:50 ` [Inter-gfx][PATCH][v3 1/4] drm/i915: fix HAS_BSD with a device info flag Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916053749.GP9765@zhen-devel.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=haihao.xiang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.