Re: [PATCH 4/4] Input: ads7846 - modificatons of _stop()/_disable() conditions

From: Tony Lindgren <tony@atomide.com>
To: Jason Wang <jason77.wang@gmail.com>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	vapier@gentoo.org, linux-input@vger.kernel.org,
	linux-omap@vger.kernel.org, grant.likely@secretlab.ca,
	roman.tereshonkov@nokia.com
Subject: Re: [PATCH 4/4] Input: ads7846 - modificatons of _stop()/_disable() conditions
Date: Mon, 18 Oct 2010 16:19:16 -0700	[thread overview]
Message-ID: <20101018231916.GL13341@atomide.com> (raw)
In-Reply-To: <4CB7BCA0.1080604@gmail.com>

* Jason Wang <jason77.wang@gmail.com> [101014 19:17]:
> Grazvydas Ignotas wrote:
> >On Thu, Oct 14, 2010 at 5:14 AM, Jason Wang <jason77.wang@gmail.com> wrote:
> >>Grazvydas Ignotas wrote:
> >>>Working here on pandora too, applied on top of linux-next (did not
> >>>test suspend though).
> >>>
> >>>Not caused by this patch, but the old problem where lower measurement
> >>>bits get lost is back - when I draw diagonal line it looks like
> >>>stairs. I think it's caused by OMAP SPI driver, CCing linux-omap.
> >>>
> >>>
> >>Yes, it is OMAP spi driver issues, I have met the same problem before,
> >>please refer to:
> >>http://www.spinics.net/lists/arm-kernel/msg91538.html
> >>
> >>you can apply this patch and test again.
> >
> >It solves my issue, thanks
> >Tested-by: Grazvydas Ignotas <notasas@gmail.com>
> >
> >BTW I have done similar patch almost 2 years ago for exactly the same problem:
> >http://marc.info/?l=linux-omap&m=122565580616920&w=2
> >but then problem went away after random kernel update (from what I
> >remember), and my patch was no longer needed.
> >
> Really similar problem and similar solution, :-)

Let's get this fix into the mainline tree then. Jason, care to
refresh (it's wrapped at least) and then repost with the acks so
Grant can queue it up for the upcoming merge window?

Acked-by: Tony Lindgren <tony@atomide.com>