All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Kim, HeungJun" <riverful.kim@samsung.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
	"Datta, Shubhrajyoti" <shubhrajyoti@ti.com>
Subject: Re: [PATCH v2 1/2] input: keyboard: MCS5080: support suspend/resume.
Date: Mon, 13 Dec 2010 01:00:26 -0800	[thread overview]
Message-ID: <20101213090026.GF21401@core.coreip.homeip.net> (raw)
In-Reply-To: <4CE6179A.5050404@samsung.com>

Hi Kim,

On Fri, Nov 19, 2010 at 03:22:18PM +0900, Kim, HeungJun wrote:
> This patch supports suspend/resume functions for mcs5080 touchkey
> driver.
> 
...

> @@ -181,6 +188,9 @@ static int __devinit mcs_touchkey_probe(struct i2c_client *client,
>  		goto err_free_irq;
>  
>  	i2c_set_clientdata(client, data);
> +
> +	pm_runtime_set_active(&client->dev);
> +

Why is this required? Won't this effectively disable PM suspend/resume?

Thanks.

-- 
Dmitry

  reply	other threads:[~2010-12-13  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  6:22 [PATCH v2 1/2] input: keyboard: MCS5080: support suspend/resume Kim, HeungJun
2010-12-13  9:00 ` Dmitry Torokhov [this message]
2010-12-13 10:20   ` Kim, HeungJun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101213090026.GF21401@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=riverful.kim@samsung.com \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.