Re: [PATCH v6 02/10] omap3: Remove unusued ISP CBUFF resource

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: balbi@ti.com
Cc: linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
	sakari.ailus@maxwell.research.nokia.com
Subject: Re: [PATCH v6 02/10] omap3: Remove unusued ISP CBUFF resource
Date: Mon, 14 Feb 2011 13:59:26 +0100	[thread overview]
Message-ID: <201102141359.27273.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20110214123106.GW2549@legolas.emea.dhcp.ti.com>

Hi Felipe,

On Monday 14 February 2011 13:31:06 Felipe Balbi wrote:
> On Mon, Feb 14, 2011 at 01:21:29PM +0100, Laurent Pinchart wrote:
> > From: Sergio Aguirre <saaguirre@ti.com>
> > 
> > The ISP CBUFF module isn't use, its resource isn't needed.
> > 
> > Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> it's unused but it's there right ? what's the problem in keeping it ?
> maybe you'd like to add name for the resources as well, there are many
> of them and keeping the order correct might be difficult. You can move
> to platform_get_resource_byname() on drivers.

But if it's unused, why keep it ? :-) There are other resources present on the 
chip (especially on older silicon versions) that are completely unused and 
even undocumented. They're not defined either.

-- 
Regards,

Laurent Pinchart