From: Kenneth Graunke <kenneth@whitecape.org>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel: Add AUB file dump support
Date: Tue, 22 Feb 2011 18:18:55 -0800 [thread overview]
Message-ID: <201102221818.55470.kenneth@whitecape.org> (raw)
In-Reply-To: <20110223014957.GR22867@zhen-devel.sh.intel.com>
On Tuesday, February 22, 2011 05:49:57 PM Zhenyu Wang wrote:
[snip]
> > We also can't commit code to Mesa that just writes into some arbitrary
> > file based on an environment variable -- keep in mind that our Mesa
> > driver is loaded from the X Server which is running as root.
>
> yeah, I wasn't aware of this, any comment for how to dump the file?
We could simply not commit this patch to master, but keep it in a branch and
apply it when we need AUB file dumping support.
Alternatively, perhaps we could commit everything, but change patch 1/3 to:
#if 0
{ "aub", DEBUG_AUB },
#endif
This makes it ridiculously easy for us to enable INTEL_DEBUG=aub, but doesn't
ship the potential security exploit. Also, since a .c file would have to be
changed, it's unlikely a distributor would accidentally enable it.
Thoughts?
next prev parent reply other threads:[~2011-02-23 2:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 6:07 AUB file dump support patches Zhenyu Wang
2011-02-16 6:07 ` [PATCH] intel: Add AUB file dump support Zhenyu Wang
2011-02-22 5:20 ` Xiang, Haihao
2011-02-22 5:51 ` Zhenyu Wang
2011-02-22 6:09 ` Xiang, Haihao
2011-02-22 6:22 ` Zhenyu Wang
2011-02-22 6:51 ` Xiang, Haihao
2011-02-22 6:55 ` Zhenyu Wang
2011-02-22 17:33 ` Eric Anholt
2011-02-23 1:49 ` Zhenyu Wang
2011-02-23 2:18 ` Kenneth Graunke [this message]
2011-02-16 6:07 ` [PATCH 1/3] intel: new debug option for aub file dump Zhenyu Wang
2011-02-16 6:07 ` [PATCH 2/3] i965: aub dump for render buffer Zhenyu Wang
2011-02-16 6:07 ` [PATCH 3/3] i965: new state cache for SF scissor on gen6 Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102221818.55470.kenneth@whitecape.org \
--to=kenneth@whitecape.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.