Re: [PATCH] mfd wm8350: allocate irq descs dynamically

From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd wm8350: allocate irq descs dynamically
Date: Thu, 19 May 2011 23:04:03 +0100	[thread overview]
Message-ID: <20110519220402.GA25452@sirena.org.uk> (raw)
In-Reply-To: <20110519185648.GR30963@pengutronix.de>

On Thu, May 19, 2011 at 08:56:48PM +0200, Sascha Hauer wrote:

> +	if (!pdata->irq_base) {
> +		wm8350->irq_base = irq_alloc_descs(-1, 0, ARRAY_SIZE(wm8350_irqs), 0);
> +		if (wm8350->irq_base < 0) {

One other thing - it doesn't seem to be 100% desirable to making the
allocation of the IRQ descriptors depend on not specifying a base - for
many situations we're likely to want to know what the numbers we end up
with are (eg, for passing to another device) but if we don't call
irq_alloc_decs() the platform still has to arrange for the descriptors
to be there in advance.  It feels like the code should always use
irq_alloc_descs(), though obviously that's not going to work right now.