From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8 v2] ARM i.MX Allow to compile together i.MX1/21/25/27
Date: Wed, 1 Jun 2011 18:47:31 +0200 [thread overview]
Message-ID: <20110601164731.GI23771@pengutronix.de> (raw)
In-Reply-To: <201106011724.26704.arnd@arndb.de>
On Wed, Jun 01, 2011 at 05:24:26PM +0200, Arnd Bergmann wrote:
> On Wednesday 01 June 2011, Sascha Hauer wrote:
> >
> > This allows for all armv4 and armv5 based i.MX systems to be compiled
> > together in one kernel. To accomplish this we need ARM_PATCH_PHYS_VIRT
> > and AUTO_ZRELADDR which is selected in Kconfig.
> > As compiling with ARM_PATCH_PHYS_VIRT breaks XIP support and different
> > PHYS_OFFSETs break uImage support the old way to integrate only one
> > of these SoCs is kept in place.
>
> Great stuff!
>
> My main concern is that it's really confusing to have so many symbols
> with slightly different scopes:
>
> * SOC_SELECT_IMX1 HAVE_SOC_IMX1 ARCH_MX1 SOC_IMX1
> * SOC_SELECT_IMX21 HAVE_SOC_IMX21 ARCH_MX2 SOC_IMX21
The ARCH_MX* macros should be removed, but some driver Kconfig entries
still depend on them.
>
> Are you sure that this is actually the minimum set that is required?
I'd love to remove some of these, but I think they are required.
SOC_SELECT_IMX1 and HAVE_SOC_IMX1 are only used to offer the right
Kconfig magic.
>
> I assume that you have gone through all the uses of these symbols
> to check that there is no silent breakage if you enable more than
> one. The only ones that looks suspicious to me are
> arch/arm/plat-mxc/include/mach/timex.h
See An earlier patch in this series. The ifdefs are removed and
CLOCK_TICK_RATE is replaced with a bogus value. CLOCK_TICK_RATE
is unused but still required to compile the kernel.
> and
> arch/arm/plat-mxc/include/mach/debug-macro.S.
This can be used only when only one family is compiled in. Doing
otherwise should be catched with an error during comppilation.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-06-01 16:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 16:47 i.MX consolidation patches Sascha Hauer
2011-05-19 16:47 ` [PATCH 1/8] ARM i.MX: fix last user of iomux.h and remove it Sascha Hauer
2011-05-19 16:47 ` [PATCH 2/8] ARM i.MX: define CLOCK_TICK_RATE to bogus value Sascha Hauer
2011-05-19 16:47 ` [PATCH 3/8] ARM i.MX: remove SoC defines around header includes Sascha Hauer
2011-05-19 16:47 ` [PATCH 4/8] ARM i.MX: dmav1: kill SoC ifdefs Sascha Hauer
2011-05-19 16:47 ` [PATCH 5/8] ARM i.MX Allow to compile together i.MX1/21/25/27 Sascha Hauer
2011-05-19 18:04 ` Uwe Kleine-König
2011-05-19 19:03 ` Sascha Hauer
2011-05-19 19:44 ` Nicolas Pitre
2011-05-19 19:50 ` Sascha Hauer
2011-06-01 13:22 ` [PATCH 5/8 v2] " Sascha Hauer
2011-06-01 13:25 ` Russell King - ARM Linux
2011-06-01 15:24 ` Arnd Bergmann
2011-06-01 16:47 ` Sascha Hauer [this message]
2011-06-01 17:59 ` Arnd Bergmann
2011-05-19 16:47 ` [PATCH 6/8] ARM i.MX mxc.h: use CONFIG_SOC_* instead of CONFIG_ARCH_* Sascha Hauer
2011-05-19 16:47 ` [PATCH 7/8] ARM i.MX debug macro: " Sascha Hauer
2011-05-19 16:54 ` Sergei Shtylyov
2011-05-19 19:07 ` Sascha Hauer
2011-05-19 16:47 ` [PATCH 8/8] ARM: mxc: update defconfigs Sascha Hauer
2011-05-30 7:57 ` i.MX consolidation patches Shawn Guo
2011-06-01 12:35 ` Sascha Hauer
2011-06-01 13:47 ` Russell King - ARM Linux
2011-06-01 14:18 ` Sascha Hauer
2011-06-01 14:24 ` Russell King - ARM Linux
2011-06-01 14:36 ` Sascha Hauer
2011-06-01 14:59 ` Uwe Kleine-König
2011-06-22 7:56 ` Sascha Hauer
2011-06-22 8:11 ` Russell King - ARM Linux
2011-06-22 8:32 ` Sascha Hauer
2011-06-22 9:03 ` Russell King - ARM Linux
2011-06-22 14:58 ` Sascha Hauer
2011-06-22 15:10 ` Arnd Bergmann
2011-06-22 15:14 ` Russell King - ARM Linux
2011-06-22 15:23 ` Arnd Bergmann
2011-06-22 15:22 ` Russell King - ARM Linux
2011-06-22 16:35 ` Sascha Hauer
2011-06-01 21:08 ` Wolfgang Denk
2011-06-01 23:04 ` Matt Sealey
2011-06-02 10:34 ` Sascha Hauer
2011-06-02 11:23 ` Russell King - ARM Linux
2011-06-02 15:46 ` Wolfgang Denk
2011-06-02 23:59 ` Matt Sealey
2011-06-03 12:02 ` Sascha Hauer
2011-06-03 12:17 ` Wolfgang Denk
2011-06-03 14:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601164731.GI23771@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.