From: Chad Versace <chad@chad-versace.us>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] dri: Add support for DRI2BufferStencil and DRI2BufferHiz
Date: Sun, 05 Jun 2011 20:38:58 -0700 [thread overview]
Message-ID: <20110606033914.C004C9E8C3@gabe.freedesktop.org> (raw)
In-Reply-To: <87tyc4b3w0.fsf@eliezer.anholt.net>
On Sun, 05 Jun 2011 10:10:39 -0700, Eric Anholt <eric@anholt.net> wrote:
> On Sat, 4 Jun 2011 17:06:31 -0700, Chad Versace <chad@chad-versace.us> wrote:
> > Before this commit, if a client were to request a stencil or hiz buffer, then
> > I830DRI2CreateBuffer() allocated and returned an X-tiled buffer by
> > accident. (DRI2BufferStencil and DRI2BufferHiz were unintentionally caught
> > by the default case of a switch statement.)
> >
> > Now, I830DRI2CreateBuffer() correctly returns a Y-tiled buffer and handles
> > the stencil buffer as a special case due its quirky pitch requirements.
> >
> > This shouldn't break older Mesa versions, because they never query (via
> > DRI2GetBuffersWithFormat) for the drawable's DRI2BufferStencil.
> >
> > Signed-off-by: Chad Versace <chad@chad-versace.us>
>
> This should make configure.ac depend on the bumped version of
> dri2proto.h, so people get an explanation instead of just build failure.
>
> Also, I'm surprised to see you didn't fix the "we'll allocate a buffer
> for *anything*" behavior that made the compat path in Mesa strange this
> time around.
Eric, I've fixed the patch series according to your comments and resubmitted.
I don't know why I didn't fix the "we'll allocate anything you ask for"
problem; guess I was just too busy digging in other things.
prev parent reply other threads:[~2011-06-06 3:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 0:06 [PATCH 0/2] ddx/dri: Add support for hiz and separate stencil buffers Chad Versace
2011-06-05 0:06 ` [PATCH 1/2] Add attachment token DRI2BufferHiz Chad Versace
2011-06-05 8:53 ` Kenneth Graunke
2011-06-06 2:32 ` Chad Versace
[not found] ` <20110606023213.7EE9D1B0093@godfather.dreamhost.com>
2011-06-06 7:22 ` Kenneth Graunke
2011-06-05 0:06 ` [PATCH 2/2] dri: Add support for DRI2BufferStencil and DRI2BufferHiz Chad Versace
2011-06-05 8:56 ` Kenneth Graunke
2011-06-05 9:48 ` Chris Wilson
2011-06-05 17:10 ` Eric Anholt
2011-06-06 3:38 ` Chad Versace [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606033914.C004C9E8C3@gabe.freedesktop.org \
--to=chad@chad-versace.us \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.