From: "J. Bruce Fields" <bfields@fieldses.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
Trond.Myklebust@netapp.com, neilb@suse.de, davem@davemloft.net
Subject: Re: [PATCH] svcsock.c: include sunrpc.h to quite sparse noise
Date: Tue, 21 Jun 2011 18:44:18 -0400 [thread overview]
Message-ID: <20110621224418.GB28047@fieldses.org> (raw)
In-Reply-To: <201106201754.51704.hartleys@visionengravers.com>
On Mon, Jun 20, 2011 at 05:54:51PM -0700, H Hartley Sweeten wrote:
> Include the private header sunrpc.h to pickup the declaration of the
> function svc_send_common to quiet the following sparse noise:
>
> warning: symbol 'svc_send_common' was not declared. Should it be static?
Thanks, applying for 3.1--b.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: Neil Brown <neilb@suse.de>
> Cc: "David S. Miller" <davem@davemloft.net>
>
> ---
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index af04f77..f2cb5b8 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -51,6 +51,8 @@
> #include <linux/sunrpc/stats.h>
> #include <linux/sunrpc/xprt.h>
>
> +#include "sunrpc.h"
> +
> #define RPCDBG_FACILITY RPCDBG_SVCXPRT
>
>
prev parent reply other threads:[~2011-06-21 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 0:54 [PATCH] svcsock.c: include sunrpc.h to quite sparse noise H Hartley Sweeten
2011-06-21 0:54 ` H Hartley Sweeten
2011-06-21 22:44 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621224418.GB28047@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.