From: Ben Widawsky <ben@bwidawsk.net>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org, Julien Cristau <jcristau@debian.org>
Subject: Re: [PATCH 1/2] drm/i915: add module parameter compiler hints
Date: Wed, 6 Jul 2011 16:16:01 -0700 [thread overview]
Message-ID: <20110706231601.GA1556@seagal.home> (raw)
In-Reply-To: <yunr563vwp9.fsf@aiko.keithp.com>
[-- Attachment #1.1: Type: text/plain, Size: 738 bytes --]
On Wed, Jul 06, 2011 at 04:03:14PM -0700, Keith Packard wrote:
> On Wed, 6 Jul 2011 15:14:52 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
>
>
> > -static int i915_modeset = -1;
> > +static int i915_modeset __read_mostly = -1;
>
> What effect does this have? Performance? Code size? More warnings?
__read_mostly attempts to put variables in a cachelines to make it more
SMP friendly. I'm not sure if there is a performance impact as a result,
but made this patch based on feedback from Chris. I've seen no
regressions on Nexuiz.
The __always_unused I don't think has any real use other than
documentation. Potentially GCC could do something useful with it, but I
don't think it's enabled anywhere important.
Ben
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-06 23:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 22:14 [PATCH 1/2] drm/i915: add module parameter compiler hints Ben Widawsky
2011-07-06 22:14 ` [PATCH 2/2] drm/i915: provide module parameter description Ben Widawsky
2011-07-07 5:58 ` Chris Wilson
2011-07-07 9:17 ` Chris Wilson
2011-07-06 23:03 ` [PATCH 1/2] drm/i915: add module parameter compiler hints Keith Packard
2011-07-06 23:16 ` Ben Widawsky [this message]
2011-07-07 0:37 ` Keith Packard
2011-07-07 16:01 ` Jesse Barnes
2011-07-07 0:48 ` Ted Phelps
2011-07-07 5:52 ` Chris Wilson
2011-07-13 18:16 ` Keith Packard
2011-07-13 21:38 Ben Widawsky
2011-07-14 8:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706231601.GA1556@seagal.home \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jcristau@debian.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.