From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: yegor_sub1@visionsystems.de, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: TPS6507X - define MFD dependencies for touch and regulator unit
Date: Mon, 11 Jul 2011 09:41:24 -0700 [thread overview]
Message-ID: <20110711164124.GB1648@core.coreip.homeip.net> (raw)
In-Reply-To: <20110711122004.GA9478@sirena.org.uk>
On Mon, Jul 11, 2011 at 01:20:04PM +0100, Mark Brown wrote:
> On Mon, Jul 11, 2011 at 12:50:19PM +0200, Yegor Yefremov wrote:
> > both touchscreen and regulator units are only working if
> > mfd device is activated. So if mfd support is enabled,
> > select TPS6507X mfd support automatically.
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> This should be split into separate patches and sent to *all* the
> relevant maintainers.
>
> > config TOUCHSCREEN_TPS6507X
> > tristate "TPS6507x based touchscreens"
> > - depends on I2C
> > + depends on I2C && MFD_SUPPORT
> > + select TPS6507X
>
> This isn't a good fix, the driver should depend on the MFD core not
> select it.
The problem with such dependencies is that user has to first enable MFD
core and then hunt through all other menus in search of the function
drivers for that chip...
Depending on what other things TPS6507X depends on it might be good idea
to go ahead and select it.
--
Dmitry
next prev parent reply other threads:[~2011-07-11 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 10:50 [PATCH] Input: TPS6507X - define MFD dependencies for touch and regulator unit Yegor Yefremov
2011-07-11 12:20 ` Mark Brown
2011-07-11 12:29 ` Yegor Yefremov
2011-07-11 14:08 ` Mark Brown
2011-07-11 16:41 ` Dmitry Torokhov [this message]
2011-07-11 22:33 ` Mark Brown
2011-07-12 8:23 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711164124.GB1648@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-input@vger.kernel.org \
--cc=yegor_sub1@visionsystems.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.