From: Daniel Vetter <daniel@ffwll.ch>
To: Keith Packard <keithp@keithp.com>, Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/7] drm: Fill in more of the DisplayPort DPCD registers
Date: Tue, 17 Jan 2012 17:07:20 +0100 [thread overview]
Message-ID: <20120117160720.GO4093@phenom.ffwll.local> (raw)
In-Reply-To: <yund3hfjf3w.fsf@aiko.keithp.com>
On Tue, Jul 12, 2011 at 03:42:11PM -0700, Keith Packard wrote:
> On Tue, 12 Jul 2011 17:37:59 -0400, Adam Jackson <ajax@redhat.com> wrote:
> > Signed-off-by: Adam Jackson <ajax@redhat.com>
>
> > +# define DP_DWN_STRM_PORT_TYPE_TMDS (2 << 1)
>
> This could be labeled TYPE_DVI_OR_HDMI according to the DP 1.1a spec.
>
> > -
>
> I find the blank lines useful in this file; they separate lists of
> values for different fields.
>
>
> > -#define DP_INTERLANE_ALIGN_DONE (1 << 0)
> > -#define DP_DOWNSTREAM_PORT_STATUS_CHANGED (1 << 6)
> > -#define DP_LINK_STATUS_UPDATED (1 << 7)
> > +# define DP_INTERLANE_ALIGN_DONE (1 << 0)
> > +# define DP_DOWNSTREAM_PORT_STATUS_CHANGED (1 << 6)
> > +# define DP_LINK_STATUS_UPDATED (1 << 7)
> >
> > #define DP_SINK_STATUS 0x205
> > -
> > -#define DP_RECEIVE_PORT_0_STATUS (1 << 0)
> > -#define DP_RECEIVE_PORT_1_STATUS (1 << 1)
> > +# define DP_RECEIVE_PORT_0_STATUS (1 << 0)
> > +# define DP_RECEIVE_PORT_1_STATUS (1 << 1)
> >
> > #define DP_ADJUST_REQUEST_LANE0_1 0x206
> > #define DP_ADJUST_REQUEST_LANE2_3 0x207
>
> Please make a separate patch for whitespace cleanups...
>
> Otherwise, these changes all match the DP 1.1a spec that I compared them
> with.
>
> Reviewed-by: Keith Packard <keithp@keithp.com>
Noticed this one here while going through list archives. Doesn't apply
properly anymore though. Adam, Dave?
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-17 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 21:37 [PATCH 0/7] Minor DisplayPort cleanup Adam Jackson
2011-07-12 21:37 ` [PATCH 1/7] drm: Fill in more of the DisplayPort DPCD registers Adam Jackson
2011-07-12 22:42 ` Keith Packard
2012-01-17 16:07 ` Daniel Vetter [this message]
2011-07-12 21:38 ` [PATCH 2/7] drm/i915/dp: Zero the DPCD data before connection probe Adam Jackson
2011-07-12 21:38 ` [PATCH 3/7] drm/i915/dp: Move DPCD dump to common code instead of PCH-only Adam Jackson
2011-07-12 21:38 ` [PATCH 4/7] drm/i915/dp: Read more DPCD registers on connection probe Adam Jackson
2011-07-12 21:38 ` [PATCH 5/7] drm/i915/dp: Better hexdump of DPCD Adam Jackson
2011-07-12 21:38 ` [PATCH 6/7] drm/i915/dp: Retry DPCD fetch on G4X too Adam Jackson
2011-07-12 21:38 ` [PATCH 7/7] drm/i915/dp: Explicitly request 8/10 channel coding Adam Jackson
2011-07-12 22:43 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117160720.GO4093@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.