Re: [PATCH] drm/i915: Don't forget to apply SNB PIPE_CONTROL GTT workaround.

From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't forget to apply SNB PIPE_CONTROL GTT workaround.
Date: Sun, 5 Aug 2012 21:46:50 +0200	[thread overview]
Message-ID: <20120805194648.GA7948@phenom.ffwll.local> (raw)
In-Reply-To: <1343774101-8569-1-git-send-email-eric@anholt.net>

On Tue, Jul 31, 2012 at 03:35:01PM -0700, Eric Anholt wrote:
> If a buffer that was the target of a PIPE_CONTROL from userland was a
> reused one that hadn't been evicted which had not previously had this
> workaround applied, then the early return for a correct
> presumed_offset in this function meant we would not bind it into the
> GTT and the write would land somewhere else.
> 
> Fixes reproducible failures with GL_EXT_timer_query usage in apitrace,
> and I also expect it to fix the intermittent OQ issues on snb that
> danvet's been working on.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48019
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Carl Worth <cworth@cworth.org>
> Tested-by: Carl Worth <cworth@cworth.org>

Picked up for -fixes, thanks for the patch. I've also added a bz line for
#52932 to the commit.

I should have noticed this while banging against this particular wall, I
guess I owe you a few beers for tracking it down ;-)

Cheers, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48