All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Wang Xingchao <xingchao.wang@intel.com>
Cc: michael.fu@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump support
Date: Wed, 15 Aug 2012 16:00:59 +0800	[thread overview]
Message-ID: <20120815080059.GB28901@localhost> (raw)
In-Reply-To: <1344329570-17939-3-git-send-email-xingchao.wang@intel.com>

Xingchao,

Have you tested the patch in haswell as well as in older hardwares?
In general it would be better if you have run this tool for some time
on several hardwares -- that's the best way to smooth out possible bugs.

> +/*Haswell registers*/

Please fix the style to (ditto for lots of other comments)

> +/* Haswell registers */

Thanks,
Fengguang

  reply	other threads:[~2012-08-15  8:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  8:52 [PATCH 0/2] Haswell intel_audio_dump support Wang Xingchao
2012-08-07  8:52 ` [PATCH V2 1/2] intel_audio_dump: fix wrong port definition Wang Xingchao
2012-08-15  7:56   ` Fengguang Wu
2012-08-07  8:52 ` [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump support Wang Xingchao
2012-08-15  8:00   ` Fengguang Wu [this message]
2012-08-15  8:05     ` Wang, Xingchao
2012-08-15  7:51 ` [PATCH 0/2] Haswell intel_audio_dump support Wang, Xingchao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120815080059.GB28901@localhost \
    --to=fengguang.wu@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michael.fu@intel.com \
    --cc=xingchao.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.