From: Daniel Vetter <daniel@ffwll.ch>
To: "Xu, Anhua" <anhua.xu@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Paul Menzel <paulepanter@users.sourceforge.net>
Subject: Re: Find bugs in i915 driver
Date: Wed, 22 Aug 2012 10:38:06 +0200 [thread overview]
Message-ID: <20120822083514.GA5186@phenom.ffwll.local> (raw)
In-Reply-To: <20120821072037.GB5156@phenom.ffwll.local>
On Tue, Aug 21, 2012 at 09:20:37AM +0200, Daniel Vetter wrote:
> On Mon, Aug 13, 2012 at 08:07:43AM +0000, Xu, Anhua wrote:
> > Hi, Paul
> >
> > Thanks for your advice. I update my patch. Please review, for your question, please see my reply below.
> >
> > From d11080eda81c0503b5035ea40667b06fe2ee0fb5 Mon Sep 17 00:00:00 2001
> > From: Anhua Xu <anhua.xu@intel.com>
> > Date: Tue, 31 Jul 2012 17:16:50 +0800
> > Subject: [PATCH v3] drm/i915: fix wrong order of parameters in port checking functions
> >
> > Wrong order of parameters passed-in when calling hdmi/adpa
> > /lvds_pipe_enabled(), 2nd and 3rd parameters are reversed.
> > This bug was indroduced by below commit:
> >
> > commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37
> > Author: Keith Packard <keithp@keithp.com>
> > Date: Sat Aug 6 10:35:34 2011 -0700
> >
> > drm/i915: Fix PCH port pipe select in CPT disable paths
> >
> > The reachable tag for this commit is v3.1-rc1-3-g1519b99
> >
> > Signed-off-by: Anhua Xu <anhua.xu@intel.com>
> > Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
>
> I've just remembered that we have a bug report that bisects to the above
> commit:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=44876
And this does indeeed fix the bug! I've moved the patch to -fixes, with cc
stable added.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-08-22 8:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 2:29 Find bugs in i915 driver Xu, Anhua
2012-07-31 7:57 ` Chris Wilson
2012-07-31 9:17 ` Xu, Anhua
2012-07-31 14:23 ` Greg KH
2012-08-01 9:31 ` Paul Menzel
2012-08-10 11:41 ` Daniel Vetter
2012-08-13 3:08 ` Xu, Anhua
2012-08-13 7:10 ` Paul Menzel
2012-08-13 8:07 ` Xu, Anhua
2012-08-21 7:20 ` Daniel Vetter
2012-08-22 8:38 ` Daniel Vetter [this message]
2012-08-13 7:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822083514.GA5186@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=anhua.xu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulepanter@users.sourceforge.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.