From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: lenb@kernel.org, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org, patches@linaro.org,
linaro-dev@lists.linaro.org, pdeschrijver@nvidia.com,
lorenzo.pieralisi@arm.com
Subject: Re: [PATCH 1/6] acpi : move the acpi_idle_driver variable declaration
Date: Tue, 11 Sep 2012 22:28:47 +0200 [thread overview]
Message-ID: <201209112228.48198.rjw@sisk.pl> (raw)
In-Reply-To: <504F1D19.1030702@linaro.org>
On Tuesday, September 11, 2012, Daniel Lezcano wrote:
> On 09/07/2012 11:19 PM, Rafael J. Wysocki wrote:
> > On Friday, September 07, 2012, Daniel Lezcano wrote:
> >> This variable is only used in the in processor_driver.c.
> >> This patch reduces the scope of the variable by moving it
> >> to this file.
> >
> > Well, the changelog is wrong (because the scope of the variable is
> > not reduced by moving it out of the header) and I don't see the point.
>
> Yes, you are right.
>
> > Is there any _real_ problem with that definition in processor.h?
>
> It is not a real problem. There is no issue fixed by this patch.
> It is just reorganizing the code little by little. The intent is to
> group what is related to cpuidle to the C files here processor_driver.c.
However, it is not recommended to put "extern something" type of declarations
into *.c files. All of them should go into headers (although not necessarily
in include/linux for that matter).
Thanks,
Rafael
next prev parent reply other threads:[~2012-09-11 20:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 10:19 [PATCH 0/6] cpuidle : per cpu latencies Daniel Lezcano
2012-09-07 10:19 ` [PATCH 1/6] acpi : move the acpi_idle_driver variable declaration Daniel Lezcano
2012-09-07 21:19 ` Rafael J. Wysocki
2012-09-11 11:14 ` Daniel Lezcano
2012-09-11 20:28 ` Rafael J. Wysocki [this message]
2012-09-07 10:19 ` [PATCH 2/6] acpi : move cpuidle_device field out of the acpi_processor_power structure Daniel Lezcano
2012-09-07 11:03 ` Amit Kucheria
2012-09-07 21:40 ` Rafael J. Wysocki
2012-09-07 21:54 ` Rafael J. Wysocki
2012-09-07 22:06 ` Rafael J. Wysocki
2012-09-11 12:20 ` Daniel Lezcano
2012-09-11 20:32 ` Rafael J. Wysocki
2012-09-07 10:19 ` [PATCH 3/6] acpi : remove pointless cpuidle device state_count init Daniel Lezcano
2012-09-07 11:01 ` Amit Kucheria
2012-09-07 21:50 ` Rafael J. Wysocki
2012-09-16 20:38 ` Daniel Lezcano
[not found] ` <505638D9.80302-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-16 21:02 ` Rafael J. Wysocki
2012-09-07 10:19 ` [PATCH 4/6] cpuidle : add a pointer for cpuidle_state in the cpuidle_device Daniel Lezcano
[not found] ` <1347013172-12465-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-07 10:19 ` [PATCH 5/6] cpuidle : use per cpuidle device cpu states Daniel Lezcano
2012-09-07 10:19 ` [PATCH 6/6] cpuidle : add cpuidle_register_states function Daniel Lezcano
2012-09-07 11:04 ` [PATCH 0/6] cpuidle : per cpu latencies Amit Kucheria
2012-09-07 12:02 ` Daniel Lezcano
2012-09-07 22:17 ` Rafael J. Wysocki
2012-09-17 8:03 ` Daniel Lezcano
2012-09-17 20:50 ` Rafael J. Wysocki
2012-09-17 21:35 ` Daniel Lezcano
2012-09-18 9:52 ` Lorenzo Pieralisi
2012-09-18 21:10 ` Rafael J. Wysocki
2012-09-18 11:19 ` Peter De Schrijver
2012-09-18 21:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209112228.48198.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=daniel.lezcano@linaro.org \
--cc=lenb@kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=patches@linaro.org \
--cc=pdeschrijver@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.