Re: [PATCH 4/4] cpuidle - support multiple drivers

From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Francesco Lavra <francescolavra.fl@gmail.com>,
	lenb@kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org,
	pdeschrijver@nvidia.com, linux-pm@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/4] cpuidle - support multiple drivers
Date: Sun, 30 Sep 2012 00:07:49 +0200	[thread overview]
Message-ID: <201209300007.49771.rjw@sisk.pl> (raw)
In-Reply-To: <50673394.5030502@linaro.org>

On Saturday, September 29, 2012, Daniel Lezcano wrote:
> On 09/29/2012 11:41 AM, Francesco Lavra wrote:
> > Hi,
> 
> Hi Francesco,
> 
> thanks for reviewing the patch.
> 
> >>  static ssize_t show_current_driver(struct device *dev,
> >>  				   struct device_attribute *attr,
> >>  				   char *buf)
> >>  {
> >> -	ssize_t ret;
> >> -	struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();
> >> +	struct cbarg cbarg = { .buf = buf };
> > 
> > cbarg.count should be initialized to 0.
> 
> Actually, with this initialization, all the fields will be initialized
> to 0, except 'buf'.

However, it would be good to initialize count explicitly so as to show
that we care about the initial value of it.

Thanks,
Rafael