From: Sakari Ailus <sakari.ailus@iki.fi>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: paul@pwsan.com, laurent.pinchart@ideasonboard.com,
linux-media@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration
Date: Wed, 10 Oct 2012 01:33:40 +0300 [thread overview]
Message-ID: <20121009223340.GM14107@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <87zk3vz7yb.fsf@deeprootsystems.com>
Hi Kevin,
Thanks for the comments!
On Tue, Oct 09, 2012 at 01:50:04PM -0700, Kevin Hilman wrote:
> Hi Sakari,
>
> Sakari Ailus <sakari.ailus@iki.fi> writes:
>
> > The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to
> > the actual CSI-2 receivers outside the ISP itself. Allow changing this
> > configuration from the ISP driver.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
>
> These control module registers (CSIRXFE, CAMERA_PHY_CTRL) are in the
> CORE powerdomain, so they will be lost during off-mode transitions. So,
> I suspect you'll also want to add them to the save/restore functions in
> control.c in order for this to work across off-mode transitions.
I've got another patch that implements this in the ISP driver instead.
<URL:http://www.spinics.net/lists/linux-media/msg54781.html>
The ISP also can't wake up the MPU from the off mode, so I don't think
losing the register contents is necessarily an issue. The registers will be
written to a new value whenever streaming is started. Perhaps adding a note
about that would be worthwhile.
Regards,
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2012-10-09 22:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 21:50 [PATCH v2 0/2] OMAP 3 CSI-2 configuration Sakari Ailus
2012-09-26 21:50 ` [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration Sakari Ailus
2012-09-27 9:20 ` Laurent Pinchart
2012-09-27 20:08 ` Sakari Ailus
2012-10-09 20:50 ` Kevin Hilman
2012-10-09 22:33 ` Sakari Ailus [this message]
2012-10-10 0:22 ` Kevin Hilman
2012-09-26 21:50 ` [PATCH v2 2/2] omap3isp: Configure CSI-2 phy based on platform data Sakari Ailus
2012-09-26 22:00 ` Tony Lindgren
2012-09-27 9:52 ` Laurent Pinchart
2012-09-28 0:00 ` Tony Lindgren
2012-09-27 14:38 ` [PATCH] omap3isp: Replace cpu_is_omap3630() with ISP revision check Laurent Pinchart
2012-09-27 23:59 ` Tony Lindgren
2012-09-27 9:51 ` [PATCH v2 2/2] omap3isp: Configure CSI-2 phy based on platform data Laurent Pinchart
2012-09-27 20:19 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009223340.GM14107@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=khilman@deeprootsystems.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.