From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: don't rewrite the GTT on resume
Date: Mon, 15 Oct 2012 08:49:08 -0700 [thread overview]
Message-ID: <20121015084908.33e1ebc2@jbarnes-t420> (raw)
In-Reply-To: <20121015074133.GA5114@phenom.ffwll.local>
On Mon, 15 Oct 2012 09:41:33 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sun, Oct 14, 2012 at 07:10:38PM -0700, Jesse Barnes wrote:
> > The BIOS shouldn't be touching this memory across suspend/resume, so
> > just leave it alone. This saves us ~50ms on resume on my T420.
>
> Is that 50ms still accurate with wc gtt ptes?
No, I haven't done timings since we switched. If we determine that the
tlb invalidate is sufficient to fix the problems we saw earlier that
made us do the rewrite, then maybe we can just remove it in favor of a
debug option to CRC the GTT PTEs per my previous patch, and remove this
code altogether.
Jesse
next prev parent reply other threads:[~2012-10-15 15:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 2:10 [PATCH 1/3] drm/i915: don't block resume on fb console resume Jesse Barnes
2012-10-15 2:10 ` [PATCH 2/3] drm/i915: put ring frequency and turbo setup into a work queue Jesse Barnes
2012-10-15 7:46 ` Daniel Vetter
2012-10-15 2:10 ` [PATCH 3/3] drm/i915: don't rewrite the GTT on resume Jesse Barnes
2012-10-15 7:41 ` Daniel Vetter
2012-10-15 15:49 ` Jesse Barnes [this message]
2012-10-15 8:37 ` Chris Wilson
2012-10-15 9:42 ` Chris Wilson
2012-10-15 15:49 ` Jesse Barnes
2012-10-15 2:32 ` [PATCH 1/3] drm/i915: don't block resume on fb console resume Dave Airlie
2012-10-15 4:49 ` Jesse Barnes
2012-10-15 7:30 ` Dave Airlie
2012-10-15 9:26 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015084908.33e1ebc2@jbarnes-t420 \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.