From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] irqchip: add basic infrastructure
Date: Sun, 28 Oct 2012 09:58:31 +0100 [thread overview]
Message-ID: <20121028095831.5e685e26@skate> (raw)
In-Reply-To: <201210271921.17472.arnd@arndb.de>
Arnd,
On Sat, 27 Oct 2012 19:21:17 +0000, Arnd Bergmann wrote:
> On Saturday 27 October 2012, Thomas Petazzoni wrote:
> > With the recent creation of the drivers/irqchip/ directory, it is
> > desirable to move irq controller drivers here. At the moment, the only
> > driver here is irq-bcm2835, the driver for the irq controller found in
> > the ARM BCM2835 SoC, present in Rasberry Pi systems. This irq
> > controller driver was exporting its initialization function and its
> > irq handling function through a header file in
> > <linux/irqchip/bcm2835.h>.
>
> Very nice series!
Thanks!
> I think it would be good if Thomas Gleixner as the IRQ subsystem maintainer
> could have a look as well. We should probably add the drivers/irqchip
> directory to that MAINTAINERS entry.
Sure.
There are however two things I am not entirely happy with:
(*) For each irqchip driver, we have to enclose the entry in the
irqchip_of_match[] array between #ifdef CONFIG... #endif. Not
really a problem, but not very pretty either, but I don't see a
simple around it (I don't think we want to define yet another
custom ELF section just for the purpose of irqchip drivers
registration).
(*) The fact that all the irqchip drivers have to mess around directly
with handle_arch_irq, which is an internal/architecture specific
symbol. But since the current drivers are only compiled when a ARM
architecture is selected, maybe it isn't a problem.
But that said, it seems like it is a good enough solution for a start.
Trying to solve those two problems would probably lead to an
over-engineered solution.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-28 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 16:45 [PATCH 1/3] irqchip: add basic infrastructure Thomas Petazzoni
2012-10-27 16:45 ` [PATCH 2/3] arm: bcm2835: convert to the irqchip infrastructure Thomas Petazzoni
2012-10-28 2:23 ` Stephen Warren
2012-10-28 9:03 ` Thomas Petazzoni
2012-10-27 16:45 ` [PATCH 3/3] arm: mvebu: move irq controller driver to drivers/irqchip Thomas Petazzoni
2012-10-28 2:25 ` Stephen Warren
2012-10-27 19:21 ` [PATCH 1/3] irqchip: add basic infrastructure Arnd Bergmann
2012-10-27 21:31 ` Thomas Gleixner
2012-10-28 8:58 ` Thomas Petazzoni [this message]
2012-10-28 2:20 ` Stephen Warren
2012-10-28 8:59 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121028095831.5e685e26@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.