Re: [PATCH 1/1] Add gem_seqno_wrap test

From: Daniel Vetter <daniel@ffwll.ch>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] Add gem_seqno_wrap test
Date: Tue, 4 Dec 2012 10:47:22 +0100	[thread overview]
Message-ID: <20121204094721.GA11556@phenom.ffwll.local> (raw)
In-Reply-To: <1354549626-10382-1-git-send-email-mika.kuoppala@intel.com>

On Mon, Dec 03, 2012 at 05:47:06PM +0200, Mika Kuoppala wrote:
> This test uses debugfs entry to set next_seqno close
> to a wrapping point and then creates a load with dependant
> buffer objects or with specified command to induce the wrap.
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---

[snip]

> +static void render_copyfunc(struct scratch_buf *src,
> +			    struct scratch_buf *dst,
> +			    int width,
> +			    int height)
> +{
> +	const int src_x = 0, src_y = 0, dst_x = 0, dst_y = 0;
> +
> +	if (IS_GEN2(devid))
> +		gen2_render_copyfunc(batch_3d,
> +				     src, src_x, src_y,
> +				     width, height,
> +				     dst, dst_x, dst_y);
> +	else if (IS_GEN3(devid))
> +		gen3_render_copyfunc(batch_3d,
> +				     src, src_x, src_y,
> +				     width, height,
> +				     dst, dst_x, dst_y);
> +	else if (IS_GEN6(devid))
> +		gen6_render_copyfunc(batch_3d,
> +				     src, src_x, src_y,
> +				     width, height,
> +				     dst, dst_x, dst_y);
> +	else if (IS_GEN7(devid))
> +		gen7_render_copyfunc(batch_3d,
> +				     src, src_x, src_y,
> +				     width, height,
> +				     dst, dst_x, dst_y);
> +	else {
> +		printf("No render copy found for this gen, test is shallow\n");
> +		intel_copy_bo(batch_blt, dst->bo, src->bo, width, height);
> +	}
> +
> +	intel_batchbuffer_flush(batch_3d);
> +}

Can you please use the new get_rendercpy_func added in

commit 64f669f7a94d459437a4dd47142ef2bb9870c5e6
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Nov 29 14:59:57 2012 +0100

    lib: extract get_render_copyfunc

That way the test will just work when we add new rendercpy support.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch