From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: fixup l3 parity sysfs access check
Date: Wed, 5 Dec 2012 08:41:25 -0800 [thread overview]
Message-ID: <20121205084125.00005815@unknown> (raw)
In-Reply-To: <1354697534-32242-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 5 Dec 2012 09:52:14 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> When l3 parity support for Haswell was enabled in
>
> commit f27b92651d72e863c308ea5dca5615fc98e38ca6
> Author: Ben Widawsky <benjamin.widawsky@intel.com>
> Date: Tue Jul 24 20:47:32 2012 -0700
>
> drm/i915: Expand DPF support to Haswell
>
> no one noticed that the patch which introduced this macro
>
> commit e1ef7cc299839e68dae3f1843f62e52acda04538
> Author: Ben Widawsky <benjamin.widawsky@intel.com>
> Date: Tue Jul 24 20:47:31 2012 -0700
>
> drm/i915: Macro to determine DPF support
>
> missed one spot. Fix this.
>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57441
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <benjamin.widawsky@intel.com>
> ---
> drivers/gpu/drm/i915/i915_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c
> b/drivers/gpu/drm/i915/i915_sysfs.c index 3bf51d5..9462081 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -97,7 +97,7 @@ static struct attribute_group rc6_attr_group = {
>
> static int l3_access_valid(struct drm_device *dev, loff_t offset)
> {
> - if (!IS_IVYBRIDGE(dev))
> + if (!HAS_L3_GPU_CACHE(dev))
> return -EPERM;
>
> if (offset % 4 != 0)
next prev parent reply other threads:[~2012-12-05 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 8:52 [PATCH] drm/i915: fixup l3 parity sysfs access check Daniel Vetter
2012-12-05 16:41 ` Ben Widawsky [this message]
2012-12-05 18:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205084125.00005815@unknown \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.