From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dhowells@redhat.com, Miklos Szeredi <miklos@szeredi.hu>,
Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
John Hubbard <jhubbard@nvidia.com>,
linux-unionfs@vger.kernel.org
Subject: Re: [PATCH v16 03/13] overlayfs: Implement splice-read
Date: Wed, 08 Mar 2023 16:04:39 +0000 [thread overview]
Message-ID: <2012343.1678291479@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230308155609.GA21508@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Mar 08, 2023 at 03:54:36PM +0000, David Howells wrote:
> > Using do_splice_to() as a helper is probably a good idea, though both Willy
> > and Christoph seem to dislike it.
>
> That's not true. What I'm fundamentlly against is pointless wrappers
> like the call_* that add no value. do_splice_to adds useful checks,
> so if properly named and documented, I'm absolutely in favour.
Fair enough. Rename to vfs_splice_read() okay with you?
David
next prev parent reply other threads:[~2023-03-08 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 14:37 [PATCH v16 00/13] splice, block: Use page pinning and kill ITER_PIPE David Howells
2023-03-08 14:37 ` [PATCH v16 01/13] splice: Clean up direct_splice_read() a bit David Howells
2023-03-08 14:37 ` [PATCH v16 02/13] shmem: Implement splice-read David Howells
2023-03-08 14:37 ` [PATCH v16 03/13] overlayfs: " David Howells
2023-03-08 15:33 ` Miklos Szeredi
2023-03-08 15:54 ` David Howells
2023-03-08 15:56 ` Christoph Hellwig
2023-03-08 16:04 ` David Howells [this message]
2023-03-09 9:29 ` Christoph Hellwig
2023-03-08 14:37 ` [PATCH v16 04/13] coda: " David Howells
2023-03-08 14:37 ` [PATCH v16 05/13] tty, proc, kernfs, random: Use direct_splice_read() David Howells
2023-03-08 14:45 ` Greg Kroah-Hartman
2023-03-08 14:37 ` [PATCH v16 06/13] splice: Do splice read from a file without using ITER_PIPE David Howells
2023-03-08 14:37 ` [PATCH v16 07/13] iov_iter: Kill ITER_PIPE David Howells
2023-03-08 14:37 ` [PATCH v16 08/13] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-03-08 14:37 ` [PATCH v16 09/13] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-03-08 14:37 ` [PATCH v16 10/13] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-03-08 14:37 ` [PATCH v16 11/13] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-03-08 14:37 ` [PATCH v16 12/13] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-03-08 14:37 ` [PATCH v16 13/13] block: convert bio_map_user_iov " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2012343.1678291479@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.