[PATCH 2/2] mxc: enable EHCI PER clock

From: gwenhael.goavec-merou@armadeus.com (gwenhael.goavec)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mxc: enable EHCI PER clock
Date: Tue, 8 Jan 2013 14:41:20 +0100	[thread overview]
Message-ID: <20130108144120.3460e935@dell> (raw)
In-Reply-To: <201301081401.36280.marex@denx.de>

On Tue, 8 Jan 2013 14:01:36 +0100
Marek Vasut <marex@denx.de> wrote:

> Dear gwenhael.goavec,
> 
> > On Wed, 19 Dec 2012 21:29:26 +0100
> > 
> > Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > > On Wed, Dec 19, 2012 at 07:29:37PM +0100, Gwenhael Goavec-Merou wrote:
> > > > EHCI PER clock (aka usb_div) must be enabled to have EHCI driver
> > > > working.
> > > > 
> > > > Signed-off-by: Gwenhael Goavec-Merou
> > > > <gwenhael.goavec-merou@armadeus.com> ---
> > > > 
> > > >  drivers/usb/host/ehci-mxc.c |   12 +++++++++++-
> > > >  1 files changed, 11 insertions(+), 1 deletions(-)
> > > > 
> > > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> > > > index ec7f5d2..8050631 100644
> > > > --- a/drivers/usb/host/ehci-mxc.c
> > > > +++ b/drivers/usb/host/ehci-mxc.c
> > > > @@ -31,7 +31,7 @@
> > > > 
> > > >  #define ULPI_VIEWPORT_OFFSET	0x170
> > > >  
> > > >  struct ehci_mxc_priv {
> > > > 
> > > > -	struct clk *usbclk, *ahbclk, *phyclk;
> > > > +	struct clk *usbclk, *ahbclk, *perclk, *phyclk;
> > > > 
> > > >  	struct usb_hcd *hcd;
> > > >  
> > > >  };
> > > > 
> > > > @@ -150,6 +150,13 @@ static int ehci_mxc_drv_probe(struct
> > > > platform_device *pdev)
> > > > 
> > > >  	}
> > > >  	clk_prepare_enable(priv->ahbclk);
> > > > 
> > > > +	priv->perclk = devm_clk_get(&pdev->dev, "per");
> > > > +	if (IS_ERR(priv->perclk)) {
> > > > +		ret = PTR_ERR(priv->perclk);
> > > > +		goto err_clk_per;
> > > > +	}
> > > > +	clk_prepare_enable(priv->perclk);
> > > 
> > > Have you checked this clock is present on all SoCs using this driver?
> > 
> > Yes
> > 
> > > Other than that, +1 on using the chipidea driver as Fabio and Marek
> > > already noted.
> > 
> > True. But I need to use a non-dt board based on imx27. Chipidea is
> > not working yet for this chip and I have currently not enough time to do
> > that.
> 
> You're on your own then, sorry :-(
> 
Yes i Know. But currently all i.MX27 based board without DT support have USB
not working.
Gwenhael