[PATCH 1/9] USB otg: use try_module_get in all usb_get_phy functions and add missing module_put

From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] USB otg: use try_module_get in all usb_get_phy functions and add missing module_put
Date: Wed, 27 Feb 2013 14:47:39 +0200	[thread overview]
Message-ID: <20130227124739.GR8016@arwen.pp.htv.fi> (raw)
In-Reply-To: <512E001D.6060004@pengutronix.de>

On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:43 PM, Felipe Balbi wrote:
> > Hi,
> > 
> > On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
> >> On 02/27/2013 01:31 PM, Felipe Balbi wrote:
> >>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
> >>>> In patch "5d3c28b usb: otg: add device tree support to otg library"
> >>>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
> >>>> phy driver in memory. The corresponding module_put() is missing in that patch.
> >>>>
> >>>> This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev().
> >>>> Further the missing module_put() is added to usb_put_phy().
> >>>>
> >>>> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
> >>>> Acked-by: Felipe Balbi <balbi@ti.com>
> >>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> >>>
> >>> this one doesn't apply to my tree. What did you use as a base ?
> >>
> >> As stated in the cover letter: Greg's usb-next.
> >>
> >> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> >>
> >> I'd really appreciate if this series goes into a single tree. So that
> >> other chipidea developers can base their work on this.
> > 
> > it eventually will all go through Greg's queue, but drivers/usb/phy and
> > drivers/usb/otg/ needs to go through my tree so we avoid conflicts
> > later, sorry.
> 
> Oh - this is going to be complicated. I'll rip the series into 3 parts
> and repost.

let's try like this:

drivers/usb/otg and drivers/usb/phy which don't create dependencies for
chipidea and other patches which create dependencies.

Then we can figure out how to handle the dependencies.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130227/e6aafe85/attachment.sig>