From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/5] clk: hi3xxx: add clock support
Date: Thu, 14 Mar 2013 09:09:21 +0000 [thread overview]
Message-ID: <201303140909.21267.arnd@arndb.de> (raw)
In-Reply-To: <1363245584-24488-3-git-send-email-haojian.zhuang@linaro.org>
On Thursday 14 March 2013, Haojian Zhuang wrote:
>
> Add clock support with device tree on Hisilicon SoC.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Looks good to me, just one final comment from my side:
> +
> +static struct hs_clk hs_clk;
> +
> +static void __init hs_init_clocks(void);
> +
Please move the hs_init_clocks() function itself to the top of the file to
avoid the forward declaration.
Arnd
next prev parent reply other threads:[~2013-03-14 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 7:19 [PATCH v4 0/5] support hisilicon SoC Haojian Zhuang
2013-03-14 7:19 ` [PATCH v4 1/5] ARM: debug: support debug ll on hisilicon soc Haojian Zhuang
2013-03-14 7:19 ` [PATCH v4 2/5] clk: hi3xxx: add clock support Haojian Zhuang
2013-03-14 9:09 ` Arnd Bergmann [this message]
2013-03-14 9:49 ` Haojian Zhuang
2013-03-14 7:19 ` [PATCH v4 3/5] ARM: hi3xxx: add board support with device tree Haojian Zhuang
2013-03-14 7:19 ` [PATCH v4 4/5] ARM: hi3xxx: enable hi4511 " Haojian Zhuang
2013-03-14 7:19 ` [PATCH v4 5/5] ARM: config: append arch hi3xxx into multi defconfig Haojian Zhuang
2013-03-14 9:10 ` Arnd Bergmann
2013-03-14 9:47 ` Haojian Zhuang
2013-03-14 13:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303140909.21267.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.