All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: fixup pd vs pt confusion in gen6 ppgtt code
Date: Tue, 19 Mar 2013 18:26:39 -0700	[thread overview]
Message-ID: <20130320012638.GC22445@bwidawsk.net> (raw)
In-Reply-To: <1363733481-13180-1-git-send-email-daniel.vetter@ffwll.ch>

On Tue, Mar 19, 2013 at 11:51:21PM +0100, Daniel Vetter wrote:
> The index variable points at a page table, not a page directory or a
> pde. Ben Widawsky fix this up correctly in his ppgtt cleanup, but I've
> botched the job and copy&pasted the old confusion from the original
> gen6 ppgtt code in
> 
> commit def886c3768d24c4e0aa56ff98b5a468c2b5c9bf
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Thu Jan 24 14:44:56 2013 -0800
> 
>     drm/i915: vfuncs for ppgtt
> 
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
[snip]
-- 
Ben Widawsky, Intel Open Source Technology Center

  reply	other threads:[~2013-03-20  1:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 22:51 [PATCH] drm/i915: fixup pd vs pt confusion in gen6 ppgtt code Daniel Vetter
2013-03-20  1:26 ` Ben Widawsky [this message]
2013-03-20 11:08 ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130320012638.GC22445@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.