Re: [PATCH 2/3] Revert "drm/i915: set TRANSCODER_EDP even earlier"

From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 2/3] Revert "drm/i915: set TRANSCODER_EDP even earlier"
Date: Fri, 22 Mar 2013 14:59:23 +0100	[thread overview]
Message-ID: <20130322135923.GT9021@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGQCS-UbCDZE3qJhUXrbBUPmR-Rkkbg-pkanSTK6boM+PQ@mail.gmail.com>

On Fri, Mar 22, 2013 at 09:30:05AM -0300, Paulo Zanoni wrote:
> 2013/3/22 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > This reverts commit cc464b2a17c59adedbdc02cc54341d630354edc3.
> >
> > The reason is that Takashi Iwai reported a regression bisected to this
> > commit:
> >
> > http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg18788.html
> >
> > His machine has eDP on port D (usual desktop all-in-on setup), which
> > intel_dp.c identifies as an eDP panel, but the hsw ddi code
> > mishandles.
> >
> > But in retrospective I also don't like that this leaks highly platform
> > specific details into common code, and the reason is that the drm
> > vblank layer sucks. So instead I think we should:
> > - move the cpu_transcoder into the dynamic pipe_config tracking (once
> >   that's merged).
> > - fix up the drm vblank layer to finally deal with kms crtc objects
> >   instead of int pipes.
> 
> Looks like we'll never get rid of all the unclaimed register errors...
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Picked up for -fixes, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch