From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/9] drm/i915: Retrieve the current mode upon KMS takeover v2
Date: Wed, 27 Mar 2013 08:52:22 -0700 [thread overview]
Message-ID: <20130327085222.31d9ecfd@jbarnes-desktop> (raw)
In-Reply-To: <20130327001347.GG9021@phenom.ffwll.local>
On Wed, 27 Mar 2013 01:13:48 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Mar 26, 2013 at 04:33:07PM -0700, Jesse Barnes wrote:
> > Read the current hardware state to retrieve the active mode and populate
> > our CRTC config if that mode matches our presumptions.
> >
> > v2: check that get_hw_state gave us a valid pipe (Imre)
> > add clock_get for ILK+ (Jesse)
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Please preheat your wrath-dispenser ...
>
> Atm the mode retrieval logic is smashed into setup_hw_state. Imo this
> needs to be part of the general hw state readout, and for paranoia needs
> to be of the usual cross-checking after each modeset.
I was thinking about this last night too; I don't like reading the
state in the fb layer either, it really belongs in intel_display
somewhere.
> Some later patches from my pipe_config series (after the pieces just
> resend) add some basic infrastructure for this, including lax matching
> ruels (e.g. for the clock cross-checking after a modeset, since we don't
> yet put the _real_ hw dotclock into adjusted_mode->clock).
I'll check it out.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-03-27 15:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 23:33 Updated fastboot patches Jesse Barnes
2013-03-26 23:33 ` [PATCH 1/9] drm/i915: Skip modifying PCH DREF if not changing clock sources Jesse Barnes
2013-03-28 7:27 ` Jani Nikula
2013-04-02 17:53 ` Daniel Vetter
2013-03-26 23:33 ` [PATCH 2/9] drm/i915: Split the framebuffer_info creation into a separate routine Jesse Barnes
2013-03-26 23:33 ` [PATCH 3/9] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v2 Jesse Barnes
2013-03-26 23:53 ` Chris Wilson
2013-03-27 14:07 ` Imre Deak
2013-03-26 23:33 ` [PATCH 4/9] drm/i915: Retrieve the current mode upon KMS takeover v2 Jesse Barnes
2013-03-26 23:36 ` Jesse Barnes
2013-03-27 0:13 ` Daniel Vetter
2013-03-27 15:52 ` Jesse Barnes [this message]
2013-03-26 23:33 ` [PATCH 5/9] drm/i915: Only preserve the BIOS modes if they are the preferred ones Jesse Barnes
2013-03-26 23:33 ` [PATCH 6/9] drm/i915: Validate that the framebuffer accommodates the current mode Jesse Barnes
2013-03-26 23:33 ` [PATCH 7/9] drm/i915: check panel fit status at update_plane time v2 Jesse Barnes
2013-03-26 23:33 ` [PATCH 8/9] drm/i915: treat no fb -> fb as simple flip instead of full mode set Jesse Barnes
2013-03-27 0:03 ` Daniel Vetter
2013-03-26 23:33 ` [PATCH 9/9] drm/i915: add debug messages for mode_valid checks Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327085222.31d9ecfd@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.