From: Thierry Reding <thierry.reding@avionic-design.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Andrew Chew <achew@nvidia.com>,
peter.ujfalusi@ti.com, acourbot@nvidia.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH V3 1/2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight
Date: Tue, 9 Apr 2013 21:40:49 +0200 [thread overview]
Message-ID: <20130409194049.GA16847@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20130409164003.GK10155@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On Tue, Apr 09, 2013 at 09:40:04AM -0700, Tony Lindgren wrote:
[...]
> But then the regulator is not found and the driver should just exit,
> or do nothing. If this is an optional regulator, then that should be
> indicated in some platform data flags?
Yes, if the regulator isn't found then the driver fails. However the
goal was to maintain bisectability. If we apply them in the wrong order
we can't guarantee that because pwm-backlight will fail to work between
both patches.
> The driver parts really must be done in independently from any platform
> data or .dts changes. The only common part needed should be changes
> to include/linux/platform_data/*.h files.
We don't even need to touch platform data because the regulators are
looked up via a global table. And the changes are all done independently
but as I mentioned above, bisectability isn't maintained, so the
preferred patch order is the one in which pwm-backlight keeps working at
each point in the commit history.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-09 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:33 [PATCH V3 0/2] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-13 22:33 ` [PATCH V3 1/2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight Andrew Chew
2013-04-08 21:46 ` Tony Lindgren
2013-04-08 21:56 ` Thierry Reding
2013-04-08 22:16 ` Tony Lindgren
2013-04-09 7:56 ` Thierry Reding
2013-04-09 16:40 ` Tony Lindgren
2013-04-09 19:40 ` Thierry Reding [this message]
2013-04-09 20:17 ` Tony Lindgren
2013-04-09 20:57 ` Thierry Reding
2013-04-09 22:27 ` Tony Lindgren
2013-03-13 22:33 ` [PATCH V3 2/2] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-14 8:44 ` [PATCH V3 0/2] Add mandatory regulator for all users of pwm-backlight Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409194049.GA16847@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=achew@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.