From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Zhong Li <zhong.li@intel.com>
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/8] gem_exec_nop.c: add vebox test case
Date: Sat, 27 Apr 2013 11:45:38 -0700 [thread overview]
Message-ID: <20130427184537.GC27969@intel.com> (raw)
In-Reply-To: <1366700809-18143-6-git-send-email-zhong.li@intel.com>
On Tue, Apr 23, 2013 at 03:06:45PM +0800, Zhong Li wrote:
> Signed-off-by: Zhong Li <zhong.li@intel.com>
> ---
> tests/gem_exec_nop.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c
> index 8608592..d0fa5d5 100644
> --- a/tests/gem_exec_nop.c
> +++ b/tests/gem_exec_nop.c
> @@ -133,7 +133,10 @@ int main(int argc, char **argv)
> if (drmtest_run_subtest("blt"))
> if (HAS_BLT_RING(devid))
> loop(fd, handle, I915_EXEC_BLT, "blt");
> -
> +
> + if (drmtest_run_subtest("vebox"))
> + if (HAS_BLT_RING(devid))
> + loop(fd, handle, I915_EXEC_VEBOX, "vebox");
>
> gem_close(fd, handle);
>
> --
> 1.7.9.5
>
Patch has the same problems as the previous ones. Fixed locally.
I don't mind so much that you made copy/paste mistakes since I do that
ALL the time too. The whitespace mistakes however should be part of your
editor setup. Please try to correct that ASAP.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-04-27 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 7:06 [PATCH 0/8] i-g-t: vebox test case Zhong Li
2013-04-23 7:06 ` [PATCH 1/8] gem_ring_sync_loop: check the rings supported by the kernel Zhong Li
2013-04-23 7:06 ` [PATCH 2/8] gem_ring_sync_loop: test the new ring Zhong Li
2013-04-23 7:06 ` [PATCH 3/8] tests: storedw on VEBOX Zhong Li
2013-04-25 1:57 ` Ben Widawsky
2013-04-23 7:06 ` [PATCH 4/8] gem_cs_tlb.c: add vebox test case Zhong Li
2013-04-27 18:40 ` Ben Widawsky
2013-04-27 18:41 ` Ben Widawsky
2013-04-23 7:06 ` [PATCH 5/8] gem_exec_nop.c: " Zhong Li
2013-04-27 18:45 ` Ben Widawsky [this message]
2013-04-28 6:07 ` Li, Zhong
2013-04-23 7:06 ` [PATCH 6/8] gem_non_secure_batch.c:add bsd and blt ring " Zhong Li
2013-04-23 7:06 ` [PATCH 7/8] gem_non_secure_batch.c add vebox " Zhong Li
2013-04-23 7:06 ` [PATCH 8/8] gem_ring_sync_loop.c: fix an operator error Zhong Li
2013-04-27 18:50 ` Ben Widawsky
2013-04-27 19:01 ` [PATCH 0/8] i-g-t: vebox test case Ben Widawsky
2013-04-28 12:02 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130427184537.GC27969@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhong.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.