From: "J. Bruce Fields" <bfields@fieldses.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: yongjun_wei@trendmicro.com.cn, linux-nfs@vger.kernel.org
Subject: Re: [PATCH -next] nfsd: make symbol nfsd_reply_cache_shrinker static
Date: Tue, 30 Apr 2013 18:20:14 -0400 [thread overview]
Message-ID: <20130430222014.GF30768@fieldses.org> (raw)
In-Reply-To: <CAPgLHd-Op0pJQq5SJi5grQB9EhupYWOf=Udrpt_PUjFsB4j9Uw@mail.gmail.com>
Applying, thanks.--b.
On Fri, Apr 05, 2013 at 09:22:39PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> symbol 'nfsd_reply_cache_shrinker' only used within this file. It should
> be static.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> fs/nfsd/nfscache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c
> index f8bb605..890a507 100644
> --- a/fs/nfsd/nfscache.c
> +++ b/fs/nfsd/nfscache.c
> @@ -56,7 +56,7 @@ static void cache_cleaner_func(struct work_struct *unused);
> static int nfsd_reply_cache_shrink(struct shrinker *shrink,
> struct shrink_control *sc);
>
> -struct shrinker nfsd_reply_cache_shrinker = {
> +static struct shrinker nfsd_reply_cache_shrinker = {
> .shrink = nfsd_reply_cache_shrink,
> .seeks = 1,
> };
>
prev parent reply other threads:[~2013-04-30 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 13:22 [PATCH -next] nfsd: make symbol nfsd_reply_cache_shrinker static Wei Yongjun
2013-04-30 22:20 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430222014.GF30768@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.