From: Josef Bacik <jbacik@fusionio.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: Josef Bacik <jbacik@fusionio.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix some basic sparse errors
Date: Mon, 19 Aug 2013 15:16:38 -0400 [thread overview]
Message-ID: <20130819191638.GD3990@localhost.localdomain> (raw)
In-Reply-To: <52126839.5060502@giantdisaster.de>
On Mon, Aug 19, 2013 at 08:47:21PM +0200, Stefan Behrens wrote:
> On 08/19/2013 20:21, Josef Bacik wrote:
> >Running sparse I found a few small things where we should have static functions
> >that aren't used externally and we should be using unsigned values for bit
> >fields. Thanks,
> >
> >Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> >---
> > fs/btrfs/disk-io.c | 8 ++++----
> > fs/btrfs/send.c | 4 ++--
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> >diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> >index 3b12c26..f51cd95 100644
> >--- a/fs/btrfs/disk-io.c
> >+++ b/fs/btrfs/disk-io.c
> >@@ -1432,8 +1432,8 @@ int btrfs_add_log_tree(struct btrfs_trans_handle *trans,
> > return 0;
> > }
> >
> >-struct btrfs_root *btrfs_read_tree_root(struct btrfs_root *tree_root,
> >- struct btrfs_key *key)
> >+static struct btrfs_root *btrfs_read_tree_root(struct btrfs_root *tree_root,
> >+ struct btrfs_key *key)
> > {
> > struct btrfs_root *root;
> > struct btrfs_fs_info *fs_info = tree_root->fs_info;
> >@@ -1533,8 +1533,8 @@ fail:
> > return ret;
> > }
>
> Already posted in "[PATCH] Btrfs: get rid of sparse warnings" on
> 14.Aug.2013.
>
> >-struct btrfs_root *btrfs_lookup_fs_root(struct btrfs_fs_info *fs_info,
> >- u64 root_id)
> >+static struct btrfs_root *btrfs_lookup_fs_root(struct btrfs_fs_info *fs_info,
> >+ u64 root_id)
> > {
> > struct btrfs_root *root;
> >
>
> Already posted in "[PATCH 1/7] btrfs: cleanup: mark 'btrfs_lookup_fs_root'
> as static" on 7.Aug.2013.
>
>
> >diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> >index fc03a57..db7da68 100644
> >--- a/fs/btrfs/send.c
> >+++ b/fs/btrfs/send.c
> >@@ -54,8 +54,8 @@ struct fs_path {
> >
> > char *buf;
> > int buf_len;
> >- int reversed:1;
> >- int virtual_mem:1;
> >+ unsigned int reversed:1;
> >+ unsigned int virtual_mem:1;
> > char inline_buf[];
> > };
> > char pad[PAGE_SIZE];
>
> Already posted in "[PATCH] Btrfs: get rid of sparse warnings" on
> 14.Aug.2013.
>
/me shakes his fist at patchwork.
Josef
prev parent reply other threads:[~2013-08-19 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 18:21 [PATCH] Btrfs: fix some basic sparse errors Josef Bacik
2013-08-19 18:47 ` Stefan Behrens
2013-08-19 19:16 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819191638.GD3990@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.