From: Samuel Ortiz <sameo@linux.intel.com>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] mc13xxx-ts: use zero as default value if no pdata was defined
Date: Tue, 20 Aug 2013 11:50:48 +0200 [thread overview]
Message-ID: <20130820095048.GC17521@zurbaran> (raw)
In-Reply-To: <20130820093432.GC26693@pengutronix.de>
Hi Michael,
On Tue, Aug 20, 2013 at 11:34:32AM +0200, Michael Grzeschik wrote:
> On Tue, Aug 20, 2013 at 03:34:33AM +0200, Samuel Ortiz wrote:
> > On Tue, Aug 13, 2013 at 02:14:30PM +0200, Michael Grzeschik wrote:
> > > In case of devicetree, we currently don't have a way to append pdata for
> > > the touchscreen. The current approach is to bail out in that case.
> > > This patch makes it possible to probe the touchscreen without pdata
> > > and use zero as default values for the atox and ato adc conversion.
> > Would that still make the touchscreen somehow functional ?
>
> Yes, it still works. It just defaults to zero values in no pdata case.
>
> > If that's the case, and if Dmitry is fine with the ts part of this
> > patch, could you please separate the mfd part of this patch into a
> > separate one ?
>
> Why?
To avoid cross tree commits as much as possible.
> The purpose of this patch is to have both cases working, pdata and no
> pdata.
I understood that part. But you can still split the patch in 2 as the ts
driver will not be probed without pdata until the mfd patch is merged
upstream.
> This patch is actually fixing the patch of Michael Thalmeier.
> There we changed the mfd and touch in one patch as well.
There was a build time dependency between the ts driver and the MFD
changes, so the patch had to be merged atomically.
That is not the case with your patch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-08-20 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 12:14 [PATCH] mc13xxx-ts: use zero as default value if no pdata was defined Michael Grzeschik
2013-08-13 16:46 ` Dmitry Torokhov
2013-08-14 3:36 ` Michael Grzeschik
2013-08-20 1:34 ` Samuel Ortiz
2013-08-20 9:34 ` Michael Grzeschik
2013-08-20 9:50 ` Samuel Ortiz [this message]
2013-08-20 9:53 ` Michael Grzeschik
2013-08-20 20:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820095048.GC17521@zurbaran \
--to=sameo@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mgr@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.